You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/26 01:43:34 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
wcarlson5 opened a new pull request #10213:
URL: https://github.com/apache/kafka/pull/10213
enforce rebalance is now used in a thread safe way
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on a change in pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on a change in pull request #10213:
URL: https://github.com/apache/kafka/pull/10213#discussion_r583330498
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -663,7 +666,6 @@ public void sendShutdownRequest(final AssignorError assignorError) {
log.warn("Detected that shutdown was requested. " +
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10213:
URL: https://github.com/apache/kafka/pull/10213#discussion_r583328928
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -663,7 +666,6 @@ public void sendShutdownRequest(final AssignorError assignorError) {
log.warn("Detected that shutdown was requested. " +
Review comment:
nit: move this to where we call `enforceRebalance` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10213:
URL: https://github.com/apache/kafka/pull/10213#issuecomment-786871581
One unrelated test failure: `kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch`
Going to merge this now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10213:
URL: https://github.com/apache/kafka/pull/10213#issuecomment-786873825
Merged to trunk and cherrypicked to 2.8 cc @vvcephei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10213:
URL: https://github.com/apache/kafka/pull/10213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org