You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2008/05/03 12:52:00 UTC
svn commit: r653046 - in /maven/artifact/branches/MNG-3010/src:
main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Author: bentmann
Date: Sat May 3 03:52:00 2008
New Revision: 653046
URL: http://svn.apache.org/viewvc?rev=653046&view=rev
Log:
o Fixed case-insensitive string handling (see http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html)
Modified:
maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
Modified: maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
URL: http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java?rev=653046&r1=653045&r2=653046&view=diff
==============================================================================
--- maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java (original)
+++ maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java Sat May 3 03:52:00 2008
@@ -24,6 +24,7 @@
import java.util.Iterator;
import java.util.List;
import java.util.ListIterator;
+import java.util.Locale;
/**
* Generic implementation of version comparison.
@@ -272,7 +273,7 @@
{
this.value = version;
- version = version.toLowerCase();
+ version = version.toLowerCase( Locale.ENGLISH );
ListItem list = items;
Modified: maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
URL: http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java?rev=653046&r1=653045&r2=653046&view=diff
==============================================================================
--- maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java (original)
+++ maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java Sat May 3 03:52:00 2008
@@ -19,6 +19,8 @@
* under the License.
*/
+import java.util.Locale;
+
import junit.framework.TestCase;
/**
@@ -138,4 +140,23 @@
checkVersionsOrder( "2.0.1", "2.0.1-123" );
checkVersionsOrder( "2.0.1-xyz", "2.0.1-123" );
}
+
+ public void testLocaleIndependent()
+ {
+ Locale orig = Locale.getDefault();
+ Locale[] locales = { Locale.ENGLISH, new Locale( "tr" ), Locale.getDefault() };
+ try
+ {
+ for ( int i = 0; i < locales.length; i++ )
+ {
+ Locale.setDefault( locales[i] );
+ checkVersionsEqual( "1-abcdefghijklmnopqrstuvwxyz", "1-ABCDEFGHIJKLMNOPQRSTUVWXYZ" );
+ }
+ }
+ finally
+ {
+ Locale.setDefault( orig );
+ }
+ }
+
}