[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #20766: [improve][broker] Unload concurrency limit during graceful shutdown

["lifepuzzlefun (via GitHub)" <gi...@apache.org>]

lifepuzzlefun commented on code in PR #20766:
URL: https://github.com/apache/pulsar/pull/20766#discussion_r1278545617


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -941,9 +942,11 @@ public void unloadNamespaceBundlesGracefully() {
         unloadNamespaceBundlesGracefully(0, true);
     }
 
-    public void unloadNamespaceBundlesGracefully(int maxConcurrentUnload, boolean closeWithoutWaitingClientDisconnect) {
+    public void unloadNamespaceBundlesGracefully(

Review Comment:
   I think this changes the behaviour before. we better take limit and timeUnit as parameter to create another method. Current adminAPI `BrokerBase.shutDownBrokerGracefully` will call this method as a persecond limit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org