Re: [PR] [fix][broker] PIP-399: Fix Metric Name for Delayed Queue [pulsar]

["thetumbled (via GitHub)" <gi...@apache.org>]

thetumbled commented on PR #23712:
URL: https://github.com/apache/pulsar/pull/23712#issuecomment-2563494134

   > > Currently, it can export metric like:
   > > ```
   > > # TYPE pulsar_delayed_message_index_size_bytes gauge
   > > pulsar_delayed_message_index_size_bytes{cluster="MyPulsar",namespace="public/default",topic="persistent://public/default/testNack-partition-0"} 0
   > > pulsar_delayed_message_index_size_bytes{cluster="MyPulsar",namespace="public/default",topic="persistent://public/default/testNack-partition-0",subscription="sub2"} 0
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > The metric of topic and subscription mix together. If we want to filter out the metric of sub to pick out the metric of topic, we need to use promsql like: `pulsar_delayed_message_index_size_bytes{subscription=""}` It is quite weird and i believe that if any user use it already, he/she will contribute a pr to fix this, as these label names can only be access by researching the code, which means he/she is an advanced user and is involved in the community probably.
   > 
   > @thetumbled Please add this directly to the description of this PR since it clarifies the issue. I'd suggest to start a discussion on that mailing list with these details. It's simplest to create a minimal PIP in any case to get this change documented.
   
   I propose a pip to discuss on this change: https://github.com/apache/pulsar/pull/23789.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org