You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by faisal-hameed <gi...@git.apache.org> on 2016/03/10 19:07:45 UTC
[GitHub] httpcore pull request: Code quality fix - Array designators "[]" s...
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/24
Code quality fix - Array designators "[]" should be on the type, not the variable
This pull request is focused on resolving occurrences of Sonar rule
squid:S1197 - Array designators "[]" should be on the type, not the variable.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1197
Please let me know if you have any questions.
Faisal Hameed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/httpcore release/array-designator-should-be-on-type-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcore/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 81c245e70b590b6378035d16c625d881a20175fd
Author: Faisal Hameed <fa...@devfactory.com>
Date: 2016-03-09T18:16:42Z
Fixing squid:S1197 - Array designators "[]" should be on the type, not the variable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request: Code quality fix - Array designators "[]" s...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/24#issuecomment-194995325
Hi,
Thank you for your patch!
Committed revision 1734442.
Gary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request #24: Code quality fix - Array designators "[]" should ...
Posted by faisal-hameed <gi...@git.apache.org>.
Github user faisal-hameed closed the pull request at:
https://github.com/apache/httpcore/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org