You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/17 20:05:46 UTC

[GitHub] [calcite] jacques-n opened a new pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

jacques-n opened a new pull request #2649:
URL: https://github.com/apache/calcite/pull/2649


   Remove extra maven repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] jacques-n merged pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

Posted by GitBox <gi...@apache.org>.
jacques-n merged pull request #2649:
URL: https://github.com/apache/calcite/pull/2649


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] jacques-n commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

Posted by GitBox <gi...@apache.org>.
jacques-n commented on a change in pull request #2649:
URL: https://github.com/apache/calcite/pull/2649#discussion_r771680894



##########
File path: elasticsearch/build.gradle.kts
##########
@@ -44,7 +38,6 @@ dependencies {
     testImplementation("org.apache.logging.log4j:log4j-api")
     testImplementation("org.apache.logging.log4j:log4j-core")
     testImplementation("org.codelibs.elasticsearch.module:lang-painless")
-    testImplementation("org.codelibs.elasticsearch.module:scripting-painless-spi")

Review comment:
       I've opened a [separate ticket](https://issues.apache.org/jira/browse/CALCITE-4948) to evaluate since we've had the `org.codelibs.elasticsearch.module:lang-painless dependency` for 2+years. For reference, it looks like [this comment](https://github.com/apache/calcite/blob/94e6272d57478a5913cb51e7df5c25e67511229a/elasticsearch/pom.xml#L113) was lost when we migrated from maven to gradle.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] jacques-n commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

Posted by GitBox <gi...@apache.org>.
jacques-n commented on a change in pull request #2649:
URL: https://github.com/apache/calcite/pull/2649#discussion_r771680894



##########
File path: elasticsearch/build.gradle.kts
##########
@@ -44,7 +38,6 @@ dependencies {
     testImplementation("org.apache.logging.log4j:log4j-api")
     testImplementation("org.apache.logging.log4j:log4j-core")
     testImplementation("org.codelibs.elasticsearch.module:lang-painless")
-    testImplementation("org.codelibs.elasticsearch.module:scripting-painless-spi")

Review comment:
       I've opened a [separate ticket|https://issues.apache.org/jira/browse/CALCITE-4948] to evaluate since we've had the `org.codelibs.elasticsearch.module:lang-painless dependency` for 2+years. For reference, it looks like [this comment](https://github.com/apache/calcite/blob/94e6272d57478a5913cb51e7df5c25e67511229a/elasticsearch/pom.xml#L113) was lost when we migrated from maven to gradle.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] vlsi commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #2649:
URL: https://github.com/apache/calcite/pull/2649#discussion_r771673340



##########
File path: elasticsearch/build.gradle.kts
##########
@@ -44,7 +38,6 @@ dependencies {
     testImplementation("org.apache.logging.log4j:log4j-api")
     testImplementation("org.apache.logging.log4j:log4j-core")
     testImplementation("org.codelibs.elasticsearch.module:lang-painless")
-    testImplementation("org.codelibs.elasticsearch.module:scripting-painless-spi")

Review comment:
       Is `org.codelibs` an authentic source of the dependencies? C
   It looks like they publish non AL2 code as if it was AL2.
   
   Should we use `org.elasticsearch.plugin:elasticsearch-scripting-painless-spi` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org