[jira] Commented: (HADOOP-995) DataNode started with illegal startup options should print usage and stop

["Boris Shkolnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643542#action_12643542 ] 

Boris Shkolnik commented on HADOOP-995:
---------------------------------------

Looks like it has been fixed.
> bin/hadoop datanode -xxx
....
Usage: java DataNode
           [-rollback]
08/10/29 10:21:50 INFO datanode.DataNode: SHUTDOWN_MSG: 



Looking at the code:
DataNode.java:parseArguments()
...
for(int i=0; i < argsLen; i++) {
      String cmd = args[i];
      if(.....
      else if(...
.....
     else 
        return false;


The only issue I see is a mismatch between the Usage message (java DataNode [-rollback] ) and the actual set of arguments we support (-rollback and - regular).

> DataNode started with illegal startup options should print usage and stop
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-995
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Konstantin Shvachko
>            Assignee: Boris Shkolnik
>
> Now that we have data-node startup options we should enforce them and not start the data-node when the options are illegal.
> Currently the data-node just ignores illegal option.
> If I start my data-node with --rack option without the argument the data-node prints the usage and starts anyway.
> If I provide an unspecified option, say -xxx, then even the usage message is not printed.
> I see an inconsistency here between the usage information and the data-node behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.