You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ParyshevSergey (via GitHub)" <gi...@apache.org> on 2023/10/12 10:07:18 UTC
[PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
ParyshevSergey opened a new pull request, #23516:
URL: https://github.com/apache/flink/pull/23516
## What is the purpose of the change
Flink SqlMonotonicity doesn't calculated for Calc/FlinkLogicalCalc/StreamPhysicalCalc that leads of absent correct monotonicity for projects. GroupAggregate, based on the input data about the monotonicity of projections make a choice about the need to retract messages.
## Brief change log
Changed logic of calculating SqlMonotonicty for Calc (base class for all Calc's) in class FlinkRelMdModifiedMonotonicity.
## Verifying this change
org.apache.flink.table.planner.runtime.stream.sql.AggregateITCase#testMaxRetract
org.apache.flink.table.planner.plan.metadata.FlinkRelMdModifiedMonotonicityTest#testMonotonicityWithCondition
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1759324534
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f5e9add87fdec27397a9415040ead85902d6f3d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f5e9add87fdec27397a9415040ead85902d6f3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f5e9add87fdec27397a9415040ead85902d6f3d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1768308509
> ## CI report:
> * [917d500](https://github.com/apache/flink/commit/917d50085911b4722155ffdb4f490e39d9a5ccde) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=53788)
>
> Bot commands
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1768294161
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1768394048
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #23516:
URL: https://github.com/apache/flink/pull/23516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1769827104
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1767856310
@snuyanzin I added the tests and also method to remove AS/CAST from rexCall operands, do the review again please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1767152943
Thanks for the contribution
Can you please also create a test for table api at `org.apache.flink.table.planner.runtime.stream.table.AggregateITCase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]
Posted by "ParyshevSergey (via GitHub)" <gi...@apache.org>.
ParyshevSergey commented on PR #23516:
URL: https://github.com/apache/flink/pull/23516#issuecomment-1768296956
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org