You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ri...@apache.org on 2006/12/13 13:03:15 UTC
svn commit: r486610 -
/incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java
Author: ritchiem
Date: Wed Dec 13 04:03:14 2006
New Revision: 486610
URL: http://svn.apache.org/viewvc?view=rev&rev=486610
Log:
QPID-172
The PoolingFilterTest.java would throw an ugly NullPointerException. This was due to there being no next filter. So Created a NoOpFilter that prevents this.
Modified:
incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java
Modified: incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java?view=diff&rev=486610&r1=486609&r2=486610
==============================================================================
--- incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java (original)
+++ incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/pool/PoolingFilterTest.java Wed Dec 13 04:03:14 2006
@@ -23,6 +23,9 @@
import junit.framework.TestCase;
import junit.framework.Assert;
import org.apache.qpid.session.TestSession;
+import org.apache.mina.common.IoFilter;
+import org.apache.mina.common.IoSession;
+import org.apache.mina.common.IdleStatus;
import java.util.concurrent.RejectedExecutionException;
@@ -43,7 +46,7 @@
public void testRejectedExecution() throws Exception
{
- _pool.filterWrite(null, new TestSession(), null);
+ _pool.filterWrite(new NoOpFilter(), new TestSession(), new IoFilter.WriteRequest("Message"));
//Shutdown the pool
_executorService.getPool().shutdownNow();
@@ -56,6 +59,46 @@
catch (RejectedExecutionException rje)
{
Assert.fail("RejectedExecutionException should not occur after pool has shutdown:" + rje);
+ }
+ }
+
+ private static class NoOpFilter implements IoFilter.NextFilter
+ {
+
+ public void sessionOpened(IoSession session)
+ {
+ }
+
+ public void sessionClosed(IoSession session)
+ {
+ }
+
+ public void sessionIdle(IoSession session, IdleStatus status)
+ {
+ }
+
+ public void exceptionCaught(IoSession session, Throwable cause)
+ {
+ }
+
+ public void messageReceived(IoSession session, Object message)
+ {
+ }
+
+ public void messageSent(IoSession session, Object message)
+ {
+ }
+
+ public void filterWrite(IoSession session, IoFilter.WriteRequest writeRequest)
+ {
+ }
+
+ public void filterClose(IoSession session)
+ {
+ }
+
+ public void sessionCreated(IoSession session)
+ {
}
}
}