[GitHub] [qpid-jms] tabish121 commented on issue #32: QPIDJMS-441: add proxy support

[GitBox <gi...@apache.org>]

tabish121 commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-545219267
 
 
   I'm not sure I agree with the testing methodology of just picking a few random tests and duplicating the entire test case.  It adds a bunch of time to the unit test run(a full minute on my machine) but I'm not sure it actually narrowly targets the changes that have been made in a manner that actually proves the changes are sound for the various bits that really matter like failover which should be testing that new proxy handlers are swapped in for different URIs etc.  Also it doesn't seem to hit cases of the proxy itself being down or malfunctioning.  I saw that Netty has a suite of tests that can simulate different error failures of the proxy itself which might be a good thing to emulate.  
   
   I'd rather see something like a ProxiedConnectionTest that covers the aspects of using the proxy where things go wrong and we ensure that they are handled.  Otherwise just running some already written tests with the proxy thrown in doesn't really test the edges.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org