You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/06/22 08:45:16 UTC
[GitHub] [camel-k] orpiske opened a new pull request #2426: Sync main with the latest changes from camel-main
orpiske opened a new pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426
<!-- Description -->
This essentially brings to main, the changes from camel-main that enabled Camel Quarkus 2.0.0 and Camel 3.10.
Please do a thorough review of the changes, as there were conflicts that had to be manually resolved.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Updates to Camel Quarkus 2.x
Updates to Camel 3.10
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#issuecomment-866543371
Thanks everyone for the review and comments! So I think there's plenty of +1s for this ... I plan to merge this today at morning, in a few hours. There's still time for more comments/reviews in case anyone finds something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a change in pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#discussion_r656302937
##########
File path: e2e/yaks/common/kamelet-beans/beans-source.kamelet.yaml
##########
@@ -0,0 +1,36 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+apiVersion: camel.apache.org/v1alpha1
+kind: Kamelet
+metadata:
+ name: beans-source
+ labels:
+ camel.apache.org/kamelet.type: "source"
+spec:
+ template:
+ beans:
+ - name: myBean
+ type: "#class:java.util.Date"
+ properties:
+ time: 0
Review comment:
Thanks! I will fix it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a change in pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#discussion_r656450605
##########
File path: script/Makefile
##########
@@ -17,7 +17,7 @@ VERSIONFILE := pkg/util/defaults/defaults.go
VERSION := 1.5.0-SNAPSHOT
OPERATOR_VERSION := $(subst -SNAPSHOT,,$(VERSION))
LAST_RELEASED_VERSION := 1.4.0
-RUNTIME_VERSION := 1.7.0
+RUNTIME_VERSION := 1.8.0-SNAPSHOT
Review comment:
Yes, that's refer to the runtime. We haven't had a 1.8 release of it yet, so that's the version we have in the `main` branch (ref. PR: https://github.com/apache/camel-k-runtime/pull/720).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a change in pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#discussion_r656450605
##########
File path: script/Makefile
##########
@@ -17,7 +17,7 @@ VERSIONFILE := pkg/util/defaults/defaults.go
VERSION := 1.5.0-SNAPSHOT
OPERATOR_VERSION := $(subst -SNAPSHOT,,$(VERSION))
LAST_RELEASED_VERSION := 1.4.0
-RUNTIME_VERSION := 1.7.0
+RUNTIME_VERSION := 1.8.0-SNAPSHOT
Review comment:
Yes, that's refer to the runtime. We haven't had a 1.8 release of it yet, so that's the version we have in `main` (ref. PR: https://github.com/apache/camel-k-runtime/pull/720).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#issuecomment-865836831
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#issuecomment-865751589
@astefanutti @lburgazzoli @nicolaferraro Some your changes had to be manually resolved due to conflicts. Therefore I marked all of you as a reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#issuecomment-866037349
The Knative issue seems an error in the Yaks test, maybe the binding used there is not up to date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske merged pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a change in pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#discussion_r656369533
##########
File path: script/Makefile
##########
@@ -17,7 +17,7 @@ VERSIONFILE := pkg/util/defaults/defaults.go
VERSION := 1.5.0-SNAPSHOT
OPERATOR_VERSION := $(subst -SNAPSHOT,,$(VERSION))
LAST_RELEASED_VERSION := 1.4.0
-RUNTIME_VERSION := 1.7.0
+RUNTIME_VERSION := 1.8.0-SNAPSHOT
Review comment:
Does this refer to `camel-k-runtime`? shouldn't be paired with `1.9.0-SNAPSHOT` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on a change in pull request #2426: Sync main with the latest changes from camel-main
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on a change in pull request #2426:
URL: https://github.com/apache/camel-k/pull/2426#discussion_r656288971
##########
File path: e2e/yaks/common/kamelet-beans/beans-source.kamelet.yaml
##########
@@ -0,0 +1,36 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+apiVersion: camel.apache.org/v1alpha1
+kind: Kamelet
+metadata:
+ name: beans-source
+ labels:
+ camel.apache.org/kamelet.type: "source"
+spec:
+ template:
+ beans:
+ - name: myBean
+ type: "#class:java.util.Date"
+ properties:
+ time: 0
Review comment:
```suggestion
property:
- key: time
value: 0
```
Back to the ugly syntax...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org