You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/05/04 12:24:31 UTC
DO NOT REPLY [Bug 51150] New: Add DecimalFormatCache.clean() method
to prevent memory leak with Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Bug #: 51150
Summary: Add DecimalFormatCache.clean() method to prevent
memory leak with Tomcat
Product: Fop
Version: 1.0
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: ognjen.d.blagojevic@gmail.com
Classification: Unclassified
Fop should provide method to clean DecimalFormatCache (and other ThreadLocals,
if any).
Tomcat 7.0.11 complains about a memory leak:
SEVERE: The web application [/(snip)] created a ThreadLocal with key of type
[org.apache.fop.util.DecimalFormatCache.DecimalFormatThreadLocal] (value
[org.apache.fop.util.DecimalFormatCache$DecimalFormatThreadLocal@fb637b]) and a
value of type [java.text.DecimalFormat] (value [java.text.DecimalFormat@674dc])
but failed to remove it when the web application was stopped. Threads are going
to be renewed over time to try and avoid a probable memory leak.
When FOP is being used with Tomcat, user should be able to add
DecimalFormatCache.clean() in destroy method of ContextListener, and prevent
memory leak.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #21 from Glenn Adams <ga...@apache.org> ---
See bug 43940, now resolved. Please verify and close if satisfied.
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Add DecimalFormatCache.clean() method to
prevent memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #3 from Andreas L. Delmelle <ad...@apache.org> 2011-05-18 18:28:19 UTC ---
(In reply to comment #2)
> I've done some more research and from what I can see DecimalFormatCache is the
> only place in the FOP source where ThreadLocal is used. So there doesn't seem
> to be any more memory leaks in the FOP code related to ThreadLocal.
>
> Would a patch that which simply removes the DecimalFormatCache be accepted
> until a better solution comes around?
No, unless it also solves the issue that prompted the use of ThreadLocal to
begin with. The reason why this is so, is because DecimalFormat is not
thread-safe. This could potentially lead to weird behavior in case of multiple
concurrent runs in the same JVM.
As for an alternative solution that would make sense: do something similar to
what was done for color profiles, i.e. make sure all usage of DecimalFormat is
properly synchronized.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Add DecimalFormatCache.clean() method to
prevent memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #2 from Unlogic <un...@unlogic.se> 2011-05-18 12:12:27 UTC ---
I've done some more research and from what I can see DecimalFormatCache is the
only place in the FOP source where ThreadLocal is used. So there doesn't seem
to be any more memory leaks in the FOP code related to ThreadLocal.
Would a patch that which simply removes the DecimalFormatCache be accepted
until a better solution comes around?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #14 from Glenn Adams <ga...@apache.org> 2012-04-24 05:41:33 UTC ---
(In reply to comment #12)
> (In reply to comment #6)
> > Ok, I will take a look if proposed pathces by Andreas and Julien for bug #43940
> > still work, and do they solve problems with Tomcat memory leak.
>
> did you have a chance to look at the proposed patch in bug 43940? does it solve
> the tomcat problem? how about performance?
Ognjen, I am still awaiting your input as requested above. if I see no further
input by April 30, I will close this bug due to lack of requested information.
Regards, Glenn
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P3
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #4 from Ognjen Blagojevic <og...@gmail.com> 2011-07-26 16:34:24 UTC ---
I just changed bug name to more proper one.
The source of the problem is this:
1. DecimalFormat is not thread safe
2. FOP uses DecimalFormat a lot
3. It takes time to instantiate DecimalFormat, so it is better to keep it for
later reuse (= to cache it).
If that is the case, I wonder, could we use some other caching mechanism
instead of ThreadLocal? Maybe Apache JCS or Ehcache could work for us? They are
both licensed under ASL2.
If you agree, I could try to create drop-in replacement for DecimalFormatCache.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #5 from Jeremias Maerki <je...@apache.org> 2011-07-26 16:58:06 UTC ---
I wonder if this bug is not a duplicate of
https://issues.apache.org/bugzilla/show_bug.cgi?id=43940
I'd rather not use a cache and possibly add another dependency just for that.
I'd rather have a thread-safe decimal formatting method. Unfortunately, I
haven't looked at the proposed solution in #43940, yet. Maybe you could take a
look and give some feedback.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #13 from Daniel Shahaf <da...@apache.org> 2012-04-09 17:39:43 UTC ---
The content of attachment 28561 has been deleted by
Daniel Shahaf <da...@apache.org>
who provided the following reason:
Message-ID: <4F...@rcub.bg.ac.rs>
The token used to delete this attachment was generated at 2012-04-09 20:39:01
IDT.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Add DecimalFormatCache.clean() method to
prevent memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Unlogic <un...@unlogic.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |unlogic@unlogic.se
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #19 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #17)
> (In reply to comment #16)
> > Patches for bug 43490 seems to be incomplete. I will try to add what is
> > missing, and then test if memory leak is gone.
>
> Patch for 43940 is now complete, and it also resolves issue with memory leak.
>
> -Ognjen
ok, as soon as there is an ICLA on file, i'll apply it
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
Severity|enhancement |normal
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #7 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:42:28 UTC ---
resetting P2 open bugs to P3 pending further review
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Add DecimalFormatCache.clean() method to
prevent memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #1 from Unlogic <un...@unlogic.se> 2011-05-18 06:39:00 UTC ---
I checked out the code from the FOP 1.0 tag and looked at the
DecimalFormatCache.
>From what I can see this type of caching using ThreadLocal will not work well
any environment where thread pools are used and where applications can be
deployed and undeployed in runtime such as J2EE web applications.
A workaround until a fix is out is to create a new thread for each PDF
generation and the let the thread from the thread pool call the join() method
on the new thread. This resolves the memory leak but on other hand makes the
cache essentially pointless.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #6 from Ognjen Blagojevic <og...@gmail.com> 2011-07-26 17:16:34 UTC ---
Ok, I will take a look if proposed pathces by Andreas and Julien for bug #43940
still work, and do they solve problems with Tomcat memory leak.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #18 from Unlogic <un...@unlogic.se> 2012-04-27 08:44:05 UTC ---
Great, will there be a FOP 1.0.1 release containing this fix or do we have to
wait until FOP 1.1 is released?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #11 from Ognjen Blagojevic <og...@gmail.com> 2012-04-09 11:10:54 UTC ---
Created attachment 28562
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28562
Same example with simplified FO file.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #15 from Unlogic <un...@unlogic.se> 2012-04-25 07:50:54 UTC ---
I took a quick look at the patch in bug 43940 and from what I can see it
replaces DecimalFormatCache with a new implementation that doesn't use
ThreadLocal at all so this bug should be fixed if/when the patch bug 43940 is
accepted and applied.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |43940
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #16 from Ognjen Blagojevic <og...@gmail.com> 2012-04-25 16:31:48 UTC ---
Patches for bug 43490 seems to be incomplete. I will try to add what is
missing, and then test if memory leak is gone.
-Ognjen
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Bug 51150 depends on bug 43940, which changed state.
Bug 43940 Summary: [PATCH] Faster method for double formatting
https://issues.apache.org/bugzilla/show_bug.cgi?id=43940
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #10 from Ognjen Blagojevic <og...@gmail.com> 2012-04-09 11:02:32 UTC ---
I attached Maven WAR project as an example.
Inside archive you will find:
1. fopleak.xml, FO file that is sufficient to trigger DecimalFormat caching
2. FopMemoryLeakServlet, with the code to transform FOP file.
Steps to reproduce:
1. Package WAR file, e.g. using Apache Maven (mvn clean package)
2. Deploy resulting war file to latest stable Apache Tomcat (tested with
7.0.27)
3. Start tomcat
4. Stop tomcat
5. Check log files. It says:
SEVERE: The web application [/fopleak] created a ThreadLocal with key of type
[org.apache.fop.util.DecimalFormatCache.DecimalFormatThreadLocal] (value
[org.apache.fop.util.DecimalFormatCache$DecimalFormatThreadLocal@1ee04fd]) and
a value of type [java.text.DecimalFormat] (value
[java.text.DecimalFormat@674dc]) but failed to remove it when the web
application was stopped. Threads are going to be renewed over time to try and
avoid a probable memory leak.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #20 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #18)
> Great, will there be a FOP 1.0.1 release containing this fix or do we have
> to wait until FOP 1.1 is released?
no on a FOP 1.0.1; an FOP 1.1 is being prepared for release, hopefully during
this quarter
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #17 from Ognjen Blagojevic <og...@gmail.com> 2012-04-27 08:37:07 UTC ---
(In reply to comment #16)
> Patches for bug 43490 seems to be incomplete. I will try to add what is
> missing, and then test if memory leak is gone.
Patch for 43940 is now complete, and it also resolves issue with memory leak.
-Ognjen
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Bug 51150 depends on bug 43940, which changed state.
Bug 43940 Summary: [PATCH] Faster method for double formatting
https://issues.apache.org/bugzilla/show_bug.cgi?id=43940
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |REOPENED
Resolution|FIXED |---
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #22 from Ognjen Blagojevic <og...@gmail.com> ---
Test project attached to this issue now doesn't complain about the leak. I'm
closing the bug.
Thank you.
-Ognjen
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
Severity|normal |enhancement
--- Comment #8 from Glenn Adams <gl...@skynav.com> 2012-04-08 05:16:07 UTC ---
please provide minimal input FO file that demonstrates problem; also, a patch
that addresses the problem would be welcome
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #12 from Glenn Adams <gl...@skynav.com> 2012-04-09 15:23:24 UTC ---
(In reply to comment #6)
> Ok, I will take a look if proposed pathces by Andreas and Julien for bug #43940
> still work, and do they solve problems with Tomcat memory leak.
did you have a chance to look at the proposed patch in bug 43940? does it solve
the tomcat problem? how about performance?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Ognjen Blagojevic <og...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add |Re-implement
|DecimalFormatCache.clean() |DecimalFormatCache to
|method to prevent memory |prevent memory leak with
|leak with Tomcat |Tomcat
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51150] Re-implement DecimalFormatCache to prevent memory leak
with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
Bug 51150 depends on bug 43940, which changed state.
Bug 43940 Summary: [PATCH] Faster method for double formatting
https://issues.apache.org/bugzilla/show_bug.cgi?id=43940
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51150] Re-implement DecimalFormatCache to prevent
memory leak with Tomcat
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51150
--- Comment #9 from Ognjen Blagojevic <og...@gmail.com> 2012-04-09 10:55:57 UTC ---
Created attachment 28561
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28561
Example demonstrating the problem
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.