You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by "William A. Rowe Jr." <wr...@rowe-clan.net> on 2012/01/06 01:56:48 UTC

Style issue

Reading the declaration of

AP_DECLARE(void *) ap_realloc(void *ptr, size_t size)
                              ap_func_attr_warn_unused_result;

macros are to be uppercase by our style guide.  (Appears in trunk only)

Re: Style issue

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.

On 1/8/2012 12:15 PM, Stefan Fritsch wrote:
> 
> True. But is this worth a major MMN bump now?

No function call signature changes, only a macro.  Does a macro name
change require an MMN bump?

Re: Style issue

Posted by Stefan Fritsch <sf...@sfritsch.de>.

On Friday 06 January 2012, William A. Rowe Jr. wrote:
> Reading the declaration of
> 
> AP_DECLARE(void *) ap_realloc(void *ptr, size_t size)
>                               ap_func_attr_warn_unused_result;
> 
> macros are to be uppercase by our style guide.  (Appears in trunk
> only)

True. But is this worth a major MMN bump now?