You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Patrick Kling <pk...@cs.uwaterloo.ca> on 2010/11/08 22:21:54 UTC
Review Request: Add listCorruptFileBlocks to FileSystem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------
Review request for hadoop-common.
Summary
-------
Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems that don't support this.
This addresses bug HADOOP-7023.
https://issues.apache.org/jira/browse/HADOOP-7023
Diffs
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/RawLocalFileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/kfs/KosmosFileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/s3/S3FileSystem.java 1032667
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java 1032667
Diff: https://reviews.apache.org/r/49/diff
Testing
-------
ant test passes
ant test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why they show up here).
Thanks,
Patrick
Re: Review Request: Add listCorruptFileBlocks to FileSystem
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------
(Updated 2010-11-22 12:19:37.183947)
Review request for hadoop-common.
Changes
-------
Changed default constructor of CorruptFileBlocks to use an empty array and empty string instead of null.
Added serialization and deserialization test case.
Summary
-------
Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems that don't support this.
This addresses bug HADOOP-7023.
https://issues.apache.org/jira/browse/HADOOP-7023
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/AbstractFileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFs.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/TestCorruptFileBlocks.java PRE-CREATION
Diff: https://reviews.apache.org/r/49/diff
Testing
-------
ant test passes
ant test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why they show up here).
Thanks,
Patrick
Re: Review Request: Add listCorruptFileBlocks to FileSystem
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------
(Updated 2010-11-18 21:02:20.305781)
Review request for hadoop-common.
Changes
-------
Added listCorruptFileBlocks to FilterFs.
Summary
-------
Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems that don't support this.
This addresses bug HADOOP-7023.
https://issues.apache.org/jira/browse/HADOOP-7023
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/AbstractFileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFs.java 1036663
Diff: https://reviews.apache.org/r/49/diff
Testing
-------
ant test passes
ant test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why they show up here).
Thanks,
Patrick
Re: Review Request: Add listCorruptFileBlocks to FileSystem
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------
(Updated 2010-11-18 20:07:20.147948)
Review request for hadoop-common.
Changes
-------
Added listCorruptFileBlocks to FileContext.
Changed FilterFileSystem to call underlying filesystem's listCorruptFileBlocks.
Summary
-------
Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems that don't support this.
This addresses bug HADOOP-7023.
https://issues.apache.org/jira/browse/HADOOP-7023
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/AbstractFileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java 1036663
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FilterFileSystem.java 1036663
Diff: https://reviews.apache.org/r/49/diff
Testing
-------
ant test passes
ant test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why they show up here).
Thanks,
Patrick
Re: Review Request: Add listCorruptFileBlocks to FileSystem
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49/
-----------------------------------------------------------
(Updated 2010-11-18 15:05:55.695348)
Review request for hadoop-common.
Changes
-------
Added default implementation of listCorruptFileBlocks to FileSystem, which throws UnsupportedOperationException. ant test-patch output is unchanged.
ant test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
As before, findbugs warnings are caused by MAPREDUCE-2172.
Summary
-------
Add listCorruptFileBlocks to FileSystem API. Throw UnsupportedOperationException for FileSystems that don't support this.
This addresses bug HADOOP-7023.
https://issues.apache.org/jira/browse/HADOOP-7023
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/CorruptFileBlocks.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileSystem.java 1036663
Diff: https://reviews.apache.org/r/49/diff
Testing
-------
ant test passes
ant test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Note: unit tests for this are included with HDFS-1482.
This patch does not actually introduce any new findbugs warnings (see MAPREDUCE-2172 for why they show up here).
Thanks,
Patrick