[GitHub] [spark] juliuszsompolski commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol

[GitBox <gi...@apache.org>]

juliuszsompolski commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and  add v11 thrift protocol
URL: https://github.com/apache/spark/pull/26221#discussion_r337965448
 
 

 ##########
 File path: sql/thriftserver/if/TCLIService.thrift
 ##########
 @@ -0,0 +1,1298 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Coding Conventions for this file:
+//
+// Structs/Enums/Unions
+// * Struct, Enum, and Union names begin with a "T",
+//   and use a capital letter for each new word, with no underscores.
+// * All fields should be declared as either optional or required.
+//
+// Functions
+// * Function names start with a capital letter and have a capital letter for
+//   each new word, with no underscores.
+// * Each function should take exactly one parameter, named TFunctionNameReq,
+//   and should return either void or TFunctionNameResp. This convention allows
+//   incremental updates.
+//
+// Services
+// * Service names begin with the letter "T", use a capital letter for each
+//   new word (with no underscores), and end with the word "Service".
+
+namespace java org.apache.spark.service.rpc.thrift
+namespace cpp apache.spark.service.rpc.thrift
 
 Review comment:
   The org.apache.hive.service package was coming because it was in the hive-service module in Hive.
   Since now it's all in one spark-thriftserver module, maybe change the package to `org.apache.spark.sql.thriftserver.cli.thrift` (as I suppose the other code will be in `org.apache.spark.sql.thriftserver`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org