You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/02 07:19:29 UTC

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2340: [CALCITE-4482] Extract the default SqlWriterConfig in SqlPrettyWriter, reduce the overhead of "ImmutableBeans.create" (Jiatao Tao)

Aaaaaaron edited a comment on pull request #2340:
URL: https://github.com/apache/calcite/pull/2340#issuecomment-771424316


   > The failed test seems irrelevant to this PR (i.e. I see the same failed check on another PR).
   
   No, just remove the code above the DEFAULT_BEAN, I didn't' see it uses config() at first 😂...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org