You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/07 14:19:47 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1728: Giant Board support (SAMA5D27 board)

patacongo commented on pull request #1728:
URL: https://github.com/apache/incubator-nuttx/pull/1728#issuecomment-688356166


   My general feeling is that this port is a little too immature to come into the repository.  The main problem is that a lot of things were clone apparently from SAMA5D4 and too many bad files and inappropriate logic came in.
   
   it would be better to strip out all unnecessary and things that do not apply to the Giant board:  NAND support, Button support, Ethernet support.  That just degrades the quality of the board port.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org