You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/30 01:00:50 UTC

[GitHub] [spark] huaxingao opened a new pull request #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

huaxingao opened a new pull request #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044
 
 
   ### What changes were proposed in this pull request?
   add getter/setter in Python FM
   
   ### Why are the changes needed?
   to be consistent with other algorithms
   
   ### Does this PR introduce any user-facing change?
   Yes. 
   add getter/setter in Python FMRegressor/FMRegressionModel/FMClassifier/FMClassificationModel
   
   ### How was this patch tested?
   doctest
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569559004
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569559004
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569864131
 
 
   Merged to master, thanks @huaxingao 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569558877
 
 
   **[Test build #115924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115924/testReport)** for PR 27044 at commit [`c141f52`](https://github.com/apache/spark/commit/c141f5250e2a359d7b4e1ca0e7337178c79fb5ce).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569559007
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20715/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569559007
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20715/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569560282
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569560286
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115924/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569560286
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115924/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569560282
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569558877
 
 
   **[Test build #115924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115924/testReport)** for PR 27044 at commit [`c141f52`](https://github.com/apache/spark/commit/c141f5250e2a359d7b4e1ca0e7337178c79fb5ce).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-569560235
 
 
   **[Test build #115924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115924/testReport)** for PR 27044 at commit [`c141f52`](https://github.com/apache/spark/commit/c141f5250e2a359d7b4e1ca0e7337178c79fb5ce).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class FMClassifier(JavaProbabilisticClassifier, _FactorizationMachinesParams, JavaMLWritable,`
     * `class FMClassificationModel(JavaProbabilisticClassificationModel, _FactorizationMachinesParams,`
     * `class _FactorizationMachinesParams(_JavaPredictorParams, HasMaxIter, HasStepSize, HasTol,`
     * `class FMRegressor(JavaPredictor, _FactorizationMachinesParams, JavaMLWritable, JavaMLReadable):`
     * `class FMRegressionModel(JavaPredictionModel, _FactorizationMachinesParams, JavaMLWritable,`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM

Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27044: [SPARK-30378][ML][PySpark] Add getter/setter in Python FM
URL: https://github.com/apache/spark/pull/27044#issuecomment-570004880
 
 
   Thank you very much!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org