You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/09 14:46:02 UTC
[GitHub] [apisix] gxthrj opened a new pull request #3006: Kv/docker whole
gxthrj opened a new pull request #3006:
URL: https://github.com/apache/apisix/pull/3006
Related to #2783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r539789408
##########
File path: README_CN.md
##########
@@ -151,6 +151,15 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵
## 立刻开始
+### 快速体验
+
+使用docker快速build一个包含所有依赖的 apisix 镜像，一键启动。
+
+```shell
+$ docker build -t apache/apisix:whole -f ./docker/Dockerfile .
+$ docker run -v ./docker/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -p 2379:2379 -d apache/apisix:whole
Review comment:
Yes, will add CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#issuecomment-742983814
Close this PR now , have resolved in https://github.com/apache/apisix-docker/pull/99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r540060315
##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,54 @@
+FROM openresty/openresty:alpine-fat AS production-stage
Review comment:
is this file copy from apisix-docker repo？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#issuecomment-742443850
> I think you should create this PR in apisix-docker repo
I think it is a quick install feature from the issue #2783 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r540063800
##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,54 @@
+FROM openresty/openresty:alpine-fat AS production-stage
Review comment:
Yes, copy some section from apisix-docker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj closed pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj closed pull request #3006:
URL: https://github.com/apache/apisix/pull/3006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r540109075
##########
File path: README.md
##########
@@ -153,6 +153,15 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
## Get Started
+### Quick start
+
+Use `docker` to quickly build an APISIX image which containing all dependencies, and start it with one click.
Review comment:
`which containing` => `which contains`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r540111032
##########
File path: README.md
##########
@@ -153,6 +153,15 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
## Get Started
+### Quick start
+
+Use `docker` to quickly build an APISIX image which containing all dependencies, and start it with one click.
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r539767514
##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,52 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+RUN set -x \
+ && /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories \
+ && apk add --no-cache --virtual .builddeps \
+ automake \
+ autoconf \
+ libtool \
+ pkgconfig \
+ cmake \
+ git \
+ && luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps \
+ && cp -v /usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix /usr/bin/ \
+ && bin='#! /usr/local/openresty/luajit/bin/luajit\npackage.path = "/usr/local/apisix/?.lua;" .. package.path' \
+ && sed -i "1s@.*@$bin@" /usr/bin/apisix \
+ && mv /usr/local/apisix/deps/share/lua/5.1/apisix /usr/local/apisix \
+ && apk del .builddeps build-base make unzip
+
+FROM alpine:3.11 AS etcd-stage
+
+WORKDIR /tmp
+
+RUN wget https://github.com/etcd-io/etcd/releases/download/v3.4.14/etcd-v3.4.14-linux-amd64.tar.gz \
Review comment:
Better to put `v3.4.14` into an ARG.
##########
File path: README_CN.md
##########
@@ -151,6 +151,15 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵
## 立刻开始
+### 快速体验
+
+使用docker快速build一个包含所有依赖的 apisix 镜像，一键启动。
+
+```shell
+$ docker build -t apache/apisix:whole -f ./docker/Dockerfile .
+$ docker run -v ./docker/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -p 2379:2379 -d apache/apisix:whole
Review comment:
Can we test this build in the CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r540104439
##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,52 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+RUN set -x \
+ && /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories \
+ && apk add --no-cache --virtual .builddeps \
+ automake \
+ autoconf \
+ libtool \
+ pkgconfig \
+ cmake \
+ git \
+ && luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps \
+ && cp -v /usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix /usr/bin/ \
+ && bin='#! /usr/local/openresty/luajit/bin/luajit\npackage.path = "/usr/local/apisix/?.lua;" .. package.path' \
+ && sed -i "1s@.*@$bin@" /usr/bin/apisix \
+ && mv /usr/local/apisix/deps/share/lua/5.1/apisix /usr/local/apisix \
+ && apk del .builddeps build-base make unzip
+
+FROM alpine:3.11 AS etcd-stage
+
+WORKDIR /tmp
+
+RUN wget https://github.com/etcd-io/etcd/releases/download/v3.4.14/etcd-v3.4.14-linux-amd64.tar.gz \
Review comment:
Done
##########
File path: README_CN.md
##########
@@ -151,6 +151,15 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵
## 立刻开始
+### 快速体验
+
+使用docker快速build一个包含所有依赖的 apisix 镜像，一键启动。
+
+```shell
+$ docker build -t apache/apisix:whole -f ./docker/Dockerfile .
+$ docker run -v ./docker/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -p 2379:2379 -d apache/apisix:whole
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r539789159
##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,52 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+RUN set -x \
+ && /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories \
+ && apk add --no-cache --virtual .builddeps \
+ automake \
+ autoconf \
+ libtool \
+ pkgconfig \
+ cmake \
+ git \
+ && luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps \
+ && cp -v /usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix /usr/bin/ \
+ && bin='#! /usr/local/openresty/luajit/bin/luajit\npackage.path = "/usr/local/apisix/?.lua;" .. package.path' \
+ && sed -i "1s@.*@$bin@" /usr/bin/apisix \
+ && mv /usr/local/apisix/deps/share/lua/5.1/apisix /usr/local/apisix \
+ && apk del .builddeps build-base make unzip
+
+FROM alpine:3.11 AS etcd-stage
+
+WORKDIR /tmp
+
+RUN wget https://github.com/etcd-io/etcd/releases/download/v3.4.14/etcd-v3.4.14-linux-amd64.tar.gz \
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3006: feat: Add docker image that contains apisix all dependencies
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#issuecomment-742437788
I think you should create this PR in apisix-docker repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org