[jira] [Commented] (AIRFLOW-4907) AWSAthenaHook - using None connection in a method

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879995#comment-16879995 ] 

ASF GitHub Bot commented on AIRFLOW-4907:
-----------------------------------------

bhavika commented on pull request #5545: [AIRFLOW-4907] AWSAthenaHook - using None connection in a method
URL: https://github.com/apache/airflow/pull/5545
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-4907) 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AWSAthenaHook - using None connection in a method
> -------------------------------------------------
>
>                 Key: AIRFLOW-4907
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4907
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: aws
>    Affects Versions: 1.10.3
>            Reporter: Bhavika
>            Assignee: Bhavika
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 1.10.4
>
>
> In the AWSAthenaHook [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/aws_athena_hook.py], the get_conn() method initializes `conn` if it's None. But the `get_state_change_reason()` method uses `conn` which is initialized to None - [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/aws_athena_hook.py#L98]
>  
>  
> Solution:
> Replace the call to `self.conn` with `self.get_conn()` in order to ensure initialization. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)