[GitHub] [incubator-superset] arpit-agarwal commented on a change in pull request #7907: [Bugfix] Response header and response mismatch on explore result from sqllab

[GitBox <gi...@apache.org>]

arpit-agarwal commented on a change in pull request #7907: [Bugfix] Response header and response mismatch on explore result from sqllab
URL: https://github.com/apache/incubator-superset/pull/7907#discussion_r305654456
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2636,7 +2636,7 @@ def sqllab_viz(self):
         table.columns = cols
         table.metrics = [SqlMetric(metric_name="count", expression="count(*)")]
         db.session.commit()
-        return self.json_response(json.dumps({"table_id": table.id}))
+        return json_success(json.dumps({"table_id": table.id}))
 
 Review comment:
   This method should produce correct response if we pass pathon object.
   In current implementation we are passing JSON.dump(obj) here.
   Most of the method in core.py when returning JSON response is using json_sucess

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org