[jira] [Commented] (MSHADE-235) Logging - Maven Quiet Mode Ignored

["Guillaume Boué (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436904#comment-15436904 ] 

Guillaume Boué commented on MSHADE-235:
---------------------------------------

Could you attach a sample project? I tried with the latest 2.4.3 version of {{maven-shade-plugin}} and I don't have those logs when running {{mvn -q}}.

The class {{MinijarFilter}} uses the logger [once the mojo is constructed|https://github.com/apache/maven-plugins/blob/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L822] so there shouldn't be that issue.

> Logging - Maven Quiet Mode Ignored
> ----------------------------------
>
>                 Key: MSHADE-235
>                 URL: https://issues.apache.org/jira/browse/MSHADE-235
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.4.3
>         Environment: $ mvn --version
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T18:41:47+02:00)
> Maven home: /home/andrewp/apache-maven-3.3.9
> Java version: 1.8.0_102, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.16.0-4-amd64", arch: "amd64", family: "unix"
>            Reporter: Andrew Pikler
>            Priority: Minor
>
> When a project is built with mvn -q, there should only be error output. However, maven shade plugins print out lines like the following:
> [INFO] javax.foo.bar not removed because it was specifically included
> This is because MinijarFilter caches the AbstractMojo logger in the constructor. The AbstractMojo documentation states specifically not to do this - http://maven.apache.org/components/ref/3.2.1/maven-plugin-api/apidocs/org/apache/maven/plugin/AbstractMojo.html#getLog()
> Perhaps removing the logger from the class and adding it as a parameter to each of the 4 methods that use it be an acceptable solution? I can write the patch myself if desired. Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)