You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/03 19:55:51 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6618: NIFI-10755 Refactor SSLContext creation using nifi-security-ssl

exceptionfactory opened a new pull request, #6618:
URL: https://github.com/apache/nifi/pull/6618

   # Summary
   
   [NIFI-10755](https://issues.apache.org/jira/browse/NIFI-10755) Refactors components in the following modules to use new `StandardSslContextBuilder` and `StandardKeyStoreBuilder` classes from `nifi-security-ssl` for creating instances of `javax.net.ssl.SSLContext`:
   
   - c2-client-http
   - minifi-bootstrap
   - nifi-site-to-site-client
   - nifi-registry-client
   - nifi-registry-framework
   - nifi-toolkit-admin
   - nifi-toolkit-cli
   
   The refactored approach reduces duplicate code related to instantiation of Key and Trust Managers, providing a standard solution without introducing additional transitive dependencies.
   
   The refactored approach allowed for the removal of `SslContextFactory` and `CertificateUtils` classes from `nifi-registry`.
   
   Implementation updates include introducing a new `StandardTrustManagerBuilder` to support instantiation of an `X509TrustManager`. Additional changes include removing incorrect usage of client authentication policy in Registry LDAP components, and setting a more generalized default TLS protocol for NiFi and Registry CLI clients.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [X] JDK 11
     - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6618: NIFI-10755 Refactor SSLContext creation using nifi-security-ssl

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6618:
URL: https://github.com/apache/nifi/pull/6618#issuecomment-1324190512

   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog closed pull request #6618: NIFI-10755 Refactor SSLContext creation using nifi-security-ssl

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6618: NIFI-10755 Refactor SSLContext creation using nifi-security-ssl
URL: https://github.com/apache/nifi/pull/6618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6618: NIFI-10755 Refactor SSLContext creation using nifi-security-ssl

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6618:
URL: https://github.com/apache/nifi/pull/6618#issuecomment-1324365987

   Reviewed code and tested this out with a 3 node secure cluster which internally used site-to-site. I also configured a secure NiFi registry on a standalone instance and was able to commit flows over HTTPS. +1 will merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org