[jira] [Commented] (DERBY-6866) Add URLs to Maven pom files

["Bryan Pendleton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135486#comment-15135486 ] 

Bryan Pendleton commented on DERBY-6866:
----------------------------------------

I don't generally run Maven, and when I tried applying the patch and going
to trunk/maven and running 'mvn install', I get an error in sign-artifacts
because I don't have a secret key (I think).

But I eyeballed the diffs and they look pretty clear to me.

And http://db.apache.org/derby certainly seems like the right URL to
be putting into our artifacts.

Any objections if I commit this patch, even though I'm not quite sure how to test it?

Unless somebody has a concern about this patch, I'll commit it in 3-4 days time.

> Add URLs to Maven pom files
> ---------------------------
>
>                 Key: DERBY-6866
>                 URL: https://issues.apache.org/jira/browse/DERBY-6866
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Bindul Bhowmik
>            Priority: Minor
>         Attachments: derby-code-pom-fix.diff
>
>
> Maven POMs have a <url> element, which is optional, but if not present Maven automatically calculates the URL using the parent project POM's URL and adding /${project.artifactId}.
> The current Maven POMs in the Derby source only has a URL defined in the parent POM ({{./maven2/pom.xml}}), but not in the other POMs. So, for any module of the project, the generated URLs are invalid.
> For, example, if you run the following in the {{./maven2/client}} directory the URL is incorrect:
> {code}
> :~/projects/apache/svn/derby-code/maven2/client$ mvn help:effective-pom | grep '^  <url>'
>   <url>http://db.apache.org/derby/derbyclient/</url>
> {code}
> This information is also used by the Maven Project Info Report plugin to generate the {{Dependencies}} report and the generated site causes {{404}} errors. For example, see http://www.deventropy.org/junit-helper/junit-helper-derby/dependencies.html#compile.
> The attached patch adds the URL element to all the POMs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)