You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Guillaume Bailleul (JIRA)" <ji...@apache.org> on 2013/08/08 21:04:48 UTC
[jira] [Commented] (PDFBOX-1684) DateConverter source is in three
places and has diverged
[ https://issues.apache.org/jira/browse/PDFBOX-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733843#comment-13733843 ]
Guillaume Bailleul commented on PDFBOX-1684:
--------------------------------------------
I partially agree with the conclusion.
Having a single copy of DateConverter is the good conclusion but I am not sure xmpbox is the right place for it. It will create a dependency between xmpbox and pdfbox where there is not today. One of the goal of the 2.0.0 release is to break PDFBox in different modules with few dependencies if possible to prevent too big footprints in different use cases.
In the package org.apache.pdfbox.util, there are some other classes that could be used in different modules (XMLUtil, StringUtil as examples).
An other idea is to create a specific little module with theses classes... but it is a new module ...
So, what are the opinions ?
> DateConverter source is in three places and has diverged
> --------------------------------------------------------
>
> Key: PDFBOX-1684
> URL: https://issues.apache.org/jira/browse/PDFBOX-1684
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.0.0
> Environment: Win 8, maven 3.0.5, svn 1.7.8 (r1419691), javac 1.7.0_25
> Reporter: Fred Hansen
> Priority: Minor
> Fix For: 2.0.0
>
>
> Versions of DateConverter,java are in three (3) packages: jempbox.impl, pdfbox.util, and xmpbox. They have diverged as updates have been made to one or the other.
> Date Converter is used in these modules:
> jempbox.xmp.ResourceEvent.java
> jempbox.xmp.XMPSchema.java
> pdfbox.cos.COSDictionary.java
> pdfbox.pdmodel.fdf.FDFAnnotation.java
> preflight.metadata.SynchronizedMetaDataValidation.java
> xmpbox.type.DateType.java
> The smallest library is xmpbox, so let's consider it as a home for DateConverter. Preflight already imports xmpbox. Pdfbox requires jempbox, so importing xmpbox into jempbox will satisfy both. Since xmpbox defines some xmp features, it seems likely that jempbox could take further advantage of xmpbox.
> Conclusion and recommendation: have a single copy of DateConverter in xmpbox.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira