You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/09/26 08:35:28 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #591:
[SCB-1498] Allow schema modification of services in production environment
codecov-io commented on issue #591: [SCB-1498] Allow schema modification of services in production environment
URL: https://github.com/apache/servicecomb-service-center/pull/591#issuecomment-535401221
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=h1) Report
> Merging [#591](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/79cd6fe81a2d02b883a84ed2f79b18952355005a?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 57.76% 57.81% +0.05%
==========================================
Files 204 204
Lines 15704 15707 +3
==========================================
+ Hits 9071 9081 +10
+ Misses 5986 5979 -7
Partials 647 647
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/microservice.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `72.22% <ø> (ø)` | :arrow_up: |
| [server/service/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [server/service/schema.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hLmdv) | `74.63% <100%> (ø)` | :arrow_up: |
| [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: |
| [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `53.57% <0%> (-0.72%)` | :arrow_down: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `80.57% <0%> (-0.58%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `69.14% <0%> (-0.38%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.53% <0%> (+0.17%)` | :arrow_up: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/591/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=footer). Last update [79cd6fe...d13a439](https://codecov.io/gh/apache/servicecomb-service-center/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services