You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Salomon Mayengue <sa...@gmail.com> on 2019/08/26 14:54:14 UTC
Re: TOMEE-2465: JDK 11 compatibility on Tomee 7.1.1 Needs an Update
Hi Jean-Louis,
Sorry for the late reply on this subject. I missed this email.
Even we are not fully JDK 11, the fixes applied are the same on this
commit: 37e56343b92996ef3bed4535a2728c034f8d7725 of the master branch.
I think it was been forgotten or something similar. After this fix, the
tests still run fine on this branch.
--
Salomon Mayengue
Le ven. 29 mars 2019 à 15:58, Jean-Louis Monteiro <jl...@tomitribe.com>
a écrit :
> I would need to refresh my mind on this.
> There are many libraries to update and a lot of work to do.
>
> Upgrading XBean on 7.1.x can be done, but under the cover ASM is updated
> too (shaded) and I'm not sure about the consequences.
>
> From a community point of view, I am not sure we can yet start backporting
> to 7.1 as we are not fully JDK 11 compliant on master yet.
>
> That being said, if someone wants to backport some changes to 7.1.x and it
> does not break the build and compatibility, not sure why it would be an
> issue.
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Mar 29, 2019 at 5:51 AM Richard Monson-Haefel <
> monsonhaefel@gmail.com> wrote:
>
> > Jean-Louis,
> >
> > This bug, reported by and assigned to Salomon Mayengue, has what looks
> > like closing comments referencing TOMEE-2272 which you fixed. Can you
> take
> > a look at it and determine if it should be closed or merged or whatever?
> > It's been unresolved since Feb 8th. Let me know the outcome if you have
> > time.
> >
> >
> >
> >
> https://jira.apache.org/jira/browse/TOMEE-2465?jql=project%20%3D%20TOMEE%20AND%20status%20in%20(%22In%20Progress%22%2C%20Resolved)%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> > --
> > Richard Monson-Haefel
> > https://twitter.com/rmonson
> > https://www.linkedin.com/in/monsonhaefel/
> >
>
Re: TOMEE-2465: JDK 11 compatibility on Tomee 7.1.1 Needs an Update
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Sorry, took some days off last week.
If you have some fixes to backport and you are willing to create a PR I'm
more than happy to review and merge for you.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Aug 26, 2019 at 4:54 PM Salomon Mayengue <sa...@gmail.com>
wrote:
> Hi Jean-Louis,
> Sorry for the late reply on this subject. I missed this email.
> Even we are not fully JDK 11, the fixes applied are the same on this
> commit: 37e56343b92996ef3bed4535a2728c034f8d7725 of the master branch.
> I think it was been forgotten or something similar. After this fix, the
> tests still run fine on this branch.
> --
> Salomon Mayengue
>
> Le ven. 29 mars 2019 à 15:58, Jean-Louis Monteiro <
> jlmonteiro@tomitribe.com> a écrit :
>
>> I would need to refresh my mind on this.
>> There are many libraries to update and a lot of work to do.
>>
>> Upgrading XBean on 7.1.x can be done, but under the cover ASM is updated
>> too (shaded) and I'm not sure about the consequences.
>>
>> From a community point of view, I am not sure we can yet start backporting
>> to 7.1 as we are not fully JDK 11 compliant on master yet.
>>
>> That being said, if someone wants to backport some changes to 7.1.x and it
>> does not break the build and compatibility, not sure why it would be an
>> issue.
>>
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Fri, Mar 29, 2019 at 5:51 AM Richard Monson-Haefel <
>> monsonhaefel@gmail.com> wrote:
>>
>> > Jean-Louis,
>> >
>> > This bug, reported by and assigned to Salomon Mayengue, has what looks
>> > like closing comments referencing TOMEE-2272 which you fixed. Can you
>> take
>> > a look at it and determine if it should be closed or merged or whatever?
>> > It's been unresolved since Feb 8th. Let me know the outcome if you have
>> > time.
>> >
>> >
>> >
>> >
>> https://jira.apache.org/jira/browse/TOMEE-2465?jql=project%20%3D%20TOMEE%20AND%20status%20in%20(%22In%20Progress%22%2C%20Resolved)%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>> > --
>> > Richard Monson-Haefel
>> > https://twitter.com/rmonson
>> > https://www.linkedin.com/in/monsonhaefel/
>> >
>>
>