You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/16 16:20:08 UTC
[GitHub] [spark] MaxGekk opened a new pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
MaxGekk opened a new pull request #33753:
URL: https://github.com/apache/spark/pull/33753
### What changes were proposed in this pull request?
Add new type `AnsiIntervalType` to `AbstractDataType.scala`, and extend it by `YearMonthIntervalType` and by `DayTimeIntervalType`
### Why are the changes needed?
To improve code maintenance. The change will allow to replace checking of both `YearMonthIntervalType` and `DayTimeIntervalType` by a check of `AnsiIntervalType`, for instance:
```scala
case _: YearMonthIntervalType | _: DayTimeIntervalType => false
```
by
```scala
case _: AnsiIntervalType => false
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By existing test suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899721676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47016/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900022414
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900215087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900182339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142535/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899677917
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47016/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899643378
**[Test build #142514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142514/testReport)** for PR 33753 at commit [`59cf48f`](https://github.com/apache/spark/commit/59cf48f76cb0d0064b11d5552e30244679b4257f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900026956
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900139911
Thanks to all. Merging to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900212014
**[Test build #142537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142537/testReport)** for PR 33753 at commit [`ac2ce78`](https://github.com/apache/spark/commit/ac2ce78ed0f1532e9d0a0bbd863dcee6ca174177).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900268514
**[Test build #142543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142543/testReport)** for PR 33753 at commit [`4273ac0`](https://github.com/apache/spark/commit/4273ac01b44b66b627b29dce7b073cc064e4fefc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900076912
**[Test build #142543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142543/testReport)** for PR 33753 at commit [`4273ac0`](https://github.com/apache/spark/commit/4273ac01b44b66b627b29dce7b073cc064e4fefc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899643740
@gengliangwang @sarutak @cloud-fan @AngersZhuuuu @beliefer @Peng-Lei Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33753:
URL: https://github.com/apache/spark/pull/33753#discussion_r690044302
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
##########
@@ -222,3 +222,10 @@ private[sql] object AnyTimestampType extends AbstractDataType with Serializable
def unapply(e: Expression): Boolean = acceptsType(e.dataType)
}
+
+/**
+ * The interval type which conforms to the ANSI SQL standard.
+ *
+ * @since 3.2.0
Review comment:
Let's also remove these since this isn't an API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900142902
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47045/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900028834
**[Test build #142537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142537/testReport)** for PR 33753 at commit [`ac2ce78`](https://github.com/apache/spark/commit/ac2ce78ed0f1532e9d0a0bbd863dcee6ca174177).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900178931
**[Test build #142535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142535/testReport)** for PR 33753 at commit [`de8f15f`](https://github.com/apache/spark/commit/de8f15fb68eb8085f6a1a59b98051bbd55d01519).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900142902
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47045/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900004377
**[Test build #142535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142535/testReport)** for PR 33753 at commit [`de8f15f`](https://github.com/apache/spark/commit/de8f15fb68eb8085f6a1a59b98051bbd55d01519).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33753:
URL: https://github.com/apache/spark/pull/33753#discussion_r690034234
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
##########
@@ -222,3 +222,11 @@ private[sql] object AnyTimestampType extends AbstractDataType with Serializable
def unapply(e: Expression): Boolean = acceptsType(e.dataType)
}
+
+/**
+ * The interval type which conforms to the ANSI SQL standard.
+ *
+ * @since 3.2.0
+ */
+@Unstable
Review comment:
ok. Let me remove `@Unstable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #33753:
URL: https://github.com/apache/spark/pull/33753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900085921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900051878
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900076912
**[Test build #142543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142543/testReport)** for PR 33753 at commit [`4273ac0`](https://github.com/apache/spark/commit/4273ac01b44b66b627b29dce7b073cc064e4fefc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33753:
URL: https://github.com/apache/spark/pull/33753#discussion_r689992717
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
##########
@@ -222,3 +222,11 @@ private[sql] object AnyTimestampType extends AbstractDataType with Serializable
def unapply(e: Expression): Boolean = acceptsType(e.dataType)
}
+
+/**
+ * The interval type which conforms to the ANSI SQL standard.
+ *
+ * @since 3.2.0
+ */
+@Unstable
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900004377
**[Test build #142535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142535/testReport)** for PR 33753 at commit [`de8f15f`](https://github.com/apache/spark/commit/de8f15fb68eb8085f6a1a59b98051bbd55d01519).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899643378
**[Test build #142514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142514/testReport)** for PR 33753 at commit [`59cf48f`](https://github.com/apache/spark/commit/59cf48f76cb0d0064b11d5552e30244679b4257f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900271677
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900215087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900182339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142535/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899823806
**[Test build #142514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142514/testReport)** for PR 33753 at commit [`59cf48f`](https://github.com/apache/spark/commit/59cf48f76cb0d0064b11d5552e30244679b4257f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900142807
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47045/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33753:
URL: https://github.com/apache/spark/pull/33753#discussion_r689991052
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
##########
@@ -222,3 +222,11 @@ private[sql] object AnyTimestampType extends AbstractDataType with Serializable
def unapply(e: Expression): Boolean = acceptsType(e.dataType)
}
+
+/**
+ * The interval type which conforms to the ANSI SQL standard.
+ *
+ * @since 3.2.0
+ */
+@Unstable
Review comment:
do we need this annotation? it's `private[sql]` and not a public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899976268
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899827153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900106214
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47045/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900085921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900085889
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900028834
**[Test build #142537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142537/testReport)** for PR 33753 at commit [`ac2ce78`](https://github.com/apache/spark/commit/ac2ce78ed0f1532e9d0a0bbd863dcee6ca174177).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-900026956
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899703085
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47016/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899721676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47016/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33753:
URL: https://github.com/apache/spark/pull/33753#issuecomment-899827153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142514/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33753: [SPARK-36524][SQL] Common class for ANSI interval types
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33753:
URL: https://github.com/apache/spark/pull/33753#discussion_r689993532
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
##########
@@ -222,3 +222,11 @@ private[sql] object AnyTimestampType extends AbstractDataType with Serializable
def unapply(e: Expression): Boolean = acceptsType(e.dataType)
}
+
+/**
+ * The interval type which conforms to the ANSI SQL standard.
+ *
+ * @since 3.2.0
+ */
+@Unstable
+private[sql] abstract class AnsiIntervalType extends AtomicType
Review comment:
Is it correct to say `AtomicType`? `CalendarIntervalType` extends `DataType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org