You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2013/08/01 23:24:50 UTC
[jclouds] Client to api deprecate (#92)
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 client-to-api-deprecate
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/92
-- Commit Summary --
* Deprecating async/client classes for a number of apis/providers
-- File Changes --
A apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/CloudSigmaApi.java (28)
M apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/CloudSigmaClient.java (2)
A apis/elasticstack/src/main/java/org/jclouds/elasticstack/ElasticStackApi.java (20)
M apis/elasticstack/src/main/java/org/jclouds/elasticstack/ElasticStackClient.java (2)
A providers/gogrid/src/main/java/org/jclouds/gogrid/GoGridApi.java (20)
M providers/gogrid/src/main/java/org/jclouds/gogrid/GoGridClient.java (2)
A providers/gogrid/src/main/java/org/jclouds/gogrid/features/GridImageApi.java (22)
A providers/gogrid/src/main/java/org/jclouds/gogrid/features/GridIpApi.java (22)
A providers/gogrid/src/main/java/org/jclouds/gogrid/features/GridJobApi.java (22)
A providers/gogrid/src/main/java/org/jclouds/gogrid/features/GridLoadBalancerApi.java (22)
A providers/gogrid/src/main/java/org/jclouds/gogrid/features/GridServerApi.java (22)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridImageAsyncClient.java (1)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridImageClient.java (1)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridIpAsyncClient.java (2)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridIpClient.java (1)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridJobAsyncClient.java (2)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridJobClient.java (1)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridLoadBalancerAsyncClient.java (2)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridLoadBalancerClient.java (1)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridServerAsyncClient.java (2)
M providers/gogrid/src/main/java/org/jclouds/gogrid/services/GridServerClient.java (1)
A providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerApi.java (20)
A providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountApi.java (20)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountAsyncClient.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountClient.java (1)
A providers/softlayer/src/main/java/org/jclouds/softlayer/features/DatacenterApi.java (20)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/DatacenterAsyncClient.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/DatacenterClient.java (1)
A providers/softlayer/src/main/java/org/jclouds/softlayer/features/ProductPackageApi.java (20)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/ProductPackageAsyncClient.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/ProductPackageClient.java (1)
A providers/softlayer/src/main/java/org/jclouds/softlayer/features/VirtualGuestApi.java (20)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/VirtualGuestAsyncClient.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/VirtualGuestClient.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/92.patch
https://github.com/jclouds/jclouds/pull/92.diff
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Bayer <no...@github.com>.
> @@ -36,7 +36,9 @@
> * @see CloudSigmaAsyncClient
> * @see <a href="TODO: insert URL of cloudsigma documentation" />
> * @author Adrian Cole
> + * @deprecated Will be renamed to CloudSigmaApi in 1.7.0.
Oh yeah, will do.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543875
Re: [jclouds] Client to api deprecate (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #565](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/565/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21980978
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Phillips <no...@github.com>.
> but it looks like they were introduced by a previous PR
One of [mine](https://github.com/jclouds/jclouds/pull/91), in fact...whoops!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21977325
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Phillips <no...@github.com>.
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +package org.jclouds.cloudsigma;
> +
> +/**
> + * Provides synchronous access to CloudSigma.
> + * <p/>
> + *
> + * @see <a href="TODO: insert URL of cloudsigma documentation" />
Something like https://lvs.cloudsigma.com/docs/? Or just remove?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543734
Re: [jclouds] Client to api deprecate (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #108](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/108/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21980446
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Phillips <no...@github.com>.
> @@ -36,7 +36,9 @@
> * @see CloudSigmaAsyncClient
> * @see <a href="TODO: insert URL of cloudsigma documentation" />
> * @author Adrian Cole
> + * @deprecated Will be renamed to CloudSigmaApi in 1.7.0.
Add a {@link CloudSigmaApi} here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543743
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Bayer <no...@github.com>.
Closed and such.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-22010993
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Phillips <no...@github.com>.
> @@ -33,7 +33,9 @@
> * @see ElasticStackAsyncClient
> * @see <a href="TODO: insert URL of elasticstack documentation" />
> * @author Adrian Cole
> + * @deprecated Renamed to ElasticStackApi in 1.7.0
Should this be "Will be renamed..." as in the first one? It's a stupid language question, I know, but I'm wondering whether this formulation could lead people to think that 1.7.0 is already out?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543761
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Bayer <no...@github.com>.
Closed #92.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Phillips <no...@github.com>.
Couple of small comments, but they shouldn't stop the merge in my opinion.
> jclouds-java-7-pull-requests #558 UNSTABLE
The [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/558/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled/) looks unrelated. We **do** have some [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/558/violations/) now, but it looks like they were introduced by a previous PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21977258
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Bayer <no...@github.com>.
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +package org.jclouds.cloudsigma;
> +
> +/**
> + * Provides synchronous access to CloudSigma.
> + * <p/>
> + *
> + * @see <a href="TODO: insert URL of cloudsigma documentation" />
I couldn't really care much. =) I'll throw that in.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543874
Re: [jclouds] Client to api deprecate (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #558](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/558/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21975281
Re: [jclouds] Client to api deprecate (#92)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #103](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/103/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92#issuecomment-21974243
Re: [jclouds] Client to api deprecate (#92)
Posted by Andrew Bayer <no...@github.com>.
> @@ -33,7 +33,9 @@
> * @see ElasticStackAsyncClient
> * @see <a href="TODO: insert URL of elasticstack documentation" />
> * @author Adrian Cole
> + * @deprecated Renamed to ElasticStackApi in 1.7.0
heh, I did that one first and then must have settled on a standard wording afterwards. Will fix!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/92/files#r5543881