You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/26 05:36:18 UTC
[GitHub] [kafka] guozhangwang opened a new pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
guozhangwang opened a new pull request #10412:
URL: https://github.com/apache/kafka/pull/10412
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #10412:
URL: https://github.com/apache/kafka/pull/10412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#issuecomment-808937665
Bumped into https://issues.apache.org/jira/browse/KAFKA-12557, there's a PR fixing it already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602561350
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -98,6 +98,9 @@ <h3><a id="streams_api_changes_300" href="#streams_api_changes_300">Streams API
</p>
<ul>
<li> <code>WindowBytesStoreSupplier#segments</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
+ <li> Overloaded <code>KafkaStreams#close</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
Review comment:
Missing note for removed methods on KeyQueryMetadata and StreamsMetadataState
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#issuecomment-808823710
@ableegoldman Thanks for the reviews. I will merge after green builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602810172
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -98,6 +98,9 @@ <h3><a id="streams_api_changes_300" href="#streams_api_changes_300">Streams API
</p>
<ul>
<li> <code>WindowBytesStoreSupplier#segments</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
+ <li> Overloaded <code>KafkaStreams#close</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
Review comment:
EDIT: deprecated APIs in KeyQueryMetadata are part of KIP-648 (2.7) so should not be removed, will add back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #10412: KAFKA-12562: Remove deprecated APIs in KafkaStreams and returned state classes
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602809191
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -98,6 +98,9 @@ <h3><a id="streams_api_changes_300" href="#streams_api_changes_300">Streams API
</p>
<ul>
<li> <code>WindowBytesStoreSupplier#segments</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
+ <li> Overloaded <code>KafkaStreams#close</code>: deprecated in Kafka 2.1.0 (<a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-319%3A+Replace+segments+with+segmentInterval+in+WindowBytesStoreSupplier">KIP-319</a>).</li>
Review comment:
KeyQueryMetadata: ah yes, will add.
StreamsMetadataState: it is the internal class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org