You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/19 16:14:14 UTC
[GitHub] [shardingsphere] null-sys opened a new pull request, #21076: setNextException with chain in classes JDBCBackendTransactionManager …
null-sys opened a new pull request, #21076:
URL: https://github.com/apache/shardingsphere/pull/21076
…and LocalTransactionManager
Fixes #20810.
Changes proposed in this pull request:
- setNextException with chain in JDBCBackendTransactionManager.class
- setNextException with chain in LocalTransactionManager.class -
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] null-sys commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by GitBox <gi...@apache.org>.
null-sys commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1271143083
@terrymanu resolved conflicts. Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1269236402
Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager …
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1251743623
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21076](https://codecov.io/gh/apache/shardingsphere/pull/21076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (671420a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ead6082cdf83b5a673d9fe3e965fa951a3ec556e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ead6082) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #21076 +/- ##
=========================================
Coverage 61.62% 61.62%
Complexity 2479 2479
=========================================
Files 4060 4060
Lines 55858 55854 -4
Branches 9462 9462
=========================================
Hits 34420 34420
+ Misses 18563 18559 -4
Partials 2875 2875
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine/core/task/InventoryIncrementalTasksRunner.java](https://codecov.io/gh/apache/shardingsphere/pull/21076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvdGFzay9JbnZlbnRvcnlJbmNyZW1lbnRhbFRhc2tzUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...dbc/transaction/JDBCBackendTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/21076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vSkRCQ0JhY2tlbmRUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `48.00% <0.00%> (+1.24%)` | :arrow_up: |
| [...tion/jdbc/transaction/LocalTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/21076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vTG9jYWxUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `50.00% <0.00%> (+2.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
URL: https://github.com/apache/shardingsphere/pull/21076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1264958352
Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1275476245
Please check the code @null-sys .In the original logic, the input parameter `[ex1, ex2]`,then the method will return `ex1 and ex1.next = ex2`;After your change,the input parameter `[ex1, ex2]`,then the method will return `ex2 and ex2.next = ex1`;It's not same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1407679031
Fixed at #23668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] null-sys commented on pull request #21076: setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager
Posted by GitBox <gi...@apache.org>.
null-sys commented on PR #21076:
URL: https://github.com/apache/shardingsphere/pull/21076#issuecomment-1275479703
> Please check the code @null-sys .In the original logic, the input parameter `[ex1, ex2]`,then the method will return `ex1 and ex1.next = ex2`;After your change,the input parameter `[ex1, ex2]`,then the method will return `ex2 and ex2.next = ex1`;It's not same.
@FlyingZC , As I understood, that was the indented change to recursively add these errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org