You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/09 06:29:27 UTC
[GitHub] [skywalking-nodejs] alanlvle opened a new pull request, #85: fix protobufjs
alanlvle opened a new pull request, #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85
https://github.com/protobufjs/protobuf.js/pull/1728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] alanlvle commented on a diff in pull request #85: Bump up grpc-node to 1.6.7 to fix CVE-2022-25878
Posted by GitBox <gi...@apache.org>.
alanlvle commented on code in PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#discussion_r893216075
##########
package-lock.json:
##########
@@ -555,24 +555,24 @@
}
},
"@grpc/grpc-js": {
- "version": "1.4.4",
- "resolved": "https://registry.npmjs.org/@grpc/grpc-js/-/grpc-js-1.4.4.tgz",
- "integrity": "sha512-a6222b7Dl6fIlMgzVl7e+NiRoLiZFbpcwvBH2Oli56Bn7W4/3Ld+86hK4ffPn5rx2DlDidmIcvIJiOQXyhv9gA==",
+ "version": "1.6.7",
+ "resolved": "https://npm.zatech.online/@grpc%2fgrpc-js/-/grpc-js-1.6.7.tgz",
+ "integrity": "sha512-eBM03pu9hd3VqDQG+kHahiG1x80RGkkqqRb1Pchcwqej/KkAH95gAvKs6laqaHCycYaPK+TKuNQnOz9UXYA8qw==",
"requires": {
"@grpc/proto-loader": "^0.6.4",
"@types/node": ">=12.12.47"
}
},
"@grpc/proto-loader": {
- "version": "0.6.7",
- "resolved": "https://registry.npmjs.org/@grpc/proto-loader/-/proto-loader-0.6.7.tgz",
- "integrity": "sha512-QzTPIyJxU0u+r2qGe8VMl3j/W2ryhEvBv7hc42OjYfthSj370fUrb7na65rG6w3YLZS/fb8p89iTBobfWGDgdw==",
+ "version": "0.6.13",
+ "resolved": "https://npm.zatech.online/@grpc%2fproto-loader/-/proto-loader-0.6.13.tgz",
Review Comment:
OK,I update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #85: Bump up grpc-node to 1.6.7 to fix CVE-2022-25878
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #85: fix protobufjs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#issuecomment-1150732393
Two things
1. Update this file according to your version bump up, https://github.com/apache/skywalking-nodejs/blob/master/dist/LICENSE#L218
2. Please make the title and description clear in the PR about which CVEs(IDs) you are going to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] alanlvle commented on pull request #85: fix protobufjs
Posted by GitBox <gi...@apache.org>.
alanlvle commented on PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#issuecomment-1150730477
Our international business monitoring uses skywalking-nodejs, the security scanning tool aquasec reports high-risk vulnerabilities, and dependencies need to be upgraded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] alanlvle commented on pull request #85: Bump up grpc-node to 1.6.7 to fix CVE-2022-25878
Posted by GitBox <gi...@apache.org>.
alanlvle commented on PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#issuecomment-1150787558
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #85: fix protobufjs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#issuecomment-1150726861
What is this version bump up about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on a diff in pull request #85: Bump up grpc-node to 1.6.7 to fix CVE-2022-25878
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #85:
URL: https://github.com/apache/skywalking-nodejs/pull/85#discussion_r893211082
##########
package-lock.json:
##########
@@ -555,24 +555,24 @@
}
},
"@grpc/grpc-js": {
- "version": "1.4.4",
- "resolved": "https://registry.npmjs.org/@grpc/grpc-js/-/grpc-js-1.4.4.tgz",
- "integrity": "sha512-a6222b7Dl6fIlMgzVl7e+NiRoLiZFbpcwvBH2Oli56Bn7W4/3Ld+86hK4ffPn5rx2DlDidmIcvIJiOQXyhv9gA==",
+ "version": "1.6.7",
+ "resolved": "https://npm.zatech.online/@grpc%2fgrpc-js/-/grpc-js-1.6.7.tgz",
+ "integrity": "sha512-eBM03pu9hd3VqDQG+kHahiG1x80RGkkqqRb1Pchcwqej/KkAH95gAvKs6laqaHCycYaPK+TKuNQnOz9UXYA8qw==",
"requires": {
"@grpc/proto-loader": "^0.6.4",
"@types/node": ">=12.12.47"
}
},
"@grpc/proto-loader": {
- "version": "0.6.7",
- "resolved": "https://registry.npmjs.org/@grpc/proto-loader/-/proto-loader-0.6.7.tgz",
- "integrity": "sha512-QzTPIyJxU0u+r2qGe8VMl3j/W2ryhEvBv7hc42OjYfthSj370fUrb7na65rG6w3YLZS/fb8p89iTBobfWGDgdw==",
+ "version": "0.6.13",
+ "resolved": "https://npm.zatech.online/@grpc%2fproto-loader/-/proto-loader-0.6.13.tgz",
Review Comment:
I think you set a proxy? This should be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org