You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/06 19:11:40 UTC

[GitHub] [superset] junlincc edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600

junlincc edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814372567


   Tested locally, Pie, World map and Bar that reported broken previously are fixed. 🙏
   The only thing I'm seeing thats abnormal is the backward button causes page crash. I don't think that's related to this PR. 
   so LGTM. 
   
   
   https://user-images.githubusercontent.com/67837651/113765486-2f403380-96d1-11eb-9f68-3c18bec566f7.mov
   
   
   @ktmud Jesse, can you help take a look at the code? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org