You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/11/14 06:49:10 UTC

svn commit: r594780 - /mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java

Author: trustin
Date: Tue Nov 13 21:49:06 2007
New Revision: 594780

URL: http://svn.apache.org/viewvc?rev=594780&view=rev
Log:
Optimized OrderedThreadPoolExecutor a little bit

Modified:
    mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java

Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java?rev=594780&r1=594779&r2=594780&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/filter/executor/OrderedThreadPoolExecutor.java Tue Nov 13 21:49:06 2007
@@ -285,10 +285,9 @@
         SessionBuffer buf = getSessionBuffer(s);
         Queue<Runnable> queue = buf.queue;
         boolean offerSession;
-        boolean offeredEvent;
-        synchronized (queue) {
-            offeredEvent = queueHandler.accept(this, e);
-            if (offeredEvent) {
+        boolean offerEvent = queueHandler.accept(this, e);
+        if (offerEvent) {
+            synchronized (queue) {
                 queue.offer(e);
                 if (buf.processingCompleted) {
                     buf.processingCompleted = false;
@@ -296,9 +295,9 @@
                 } else {
                     offerSession = false;
                 }
-            } else {
-                offerSession = false;
-            }
+            }            
+        } else {
+            offerSession = false;
         }
         
         if (offerSession) {
@@ -307,7 +306,7 @@
         
         addWorkerIfNecessary();
         
-        if (offeredEvent) {
+        if (offerEvent) {
             queueHandler.offered(this, e);
         }
     }