You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2014/07/24 22:56:31 UTC
[GitHub] incubator-storm pull request: [STORM-406] Fix for reconnect logic ...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/incubator-storm/pull/205
[STORM-406] Fix for reconnect logic in netty client
- Check if channel ``isConnected``.
- Reconnect if not before start of each batch.
- Increase max-retried for netty client so that other worker get enough time to start/restart and starts accepting new netty connections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm netty-client-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit e1e6a602e330d71410b1876ca9fb6bfc29761f35
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2014-07-24T19:34:38Z
Fix netty client reconnect issue
commit 9b3a632340b66f1fe493220c0e6c22c2912e8025
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2014-07-24T19:36:41Z
Increase netty max retries defaults allowing more time for other workers to come up
commit f1f5ecd92c7ea55d01163c8dbc2360466f34fd3a
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2014-07-24T20:49:22Z
Increase max tries and reset local channel variable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-406] Fix for reconnect logic ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/205#issuecomment-50173838
That change looks simple enough. My only concern was with us calling isConnected a lot on the channel, but looking at the code for it in 3.6.3.Final for the socketChannel it looks like it is just checking a variable, so I think it should be fine. I am +1 on the change, but want to give some more time for others to comment/look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-406] Fix for reconnect logic ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---