[GitHub] [superset] cemremengu commented on pull request #19421: perf: refactor SIP-68 db migrations with INSERT SELECT FROM

[GitBox <gi...@apache.org>]

cemremengu commented on PR #19421:
URL: https://github.com/apache/superset/pull/19421#issuecomment-1103610763

   I get the following error when applying this migration. Even if I update the column to be `False` by default it still does not work. Any ideas?
   
   ```
   INFO  [alembic.runtime.migration] Running upgrade ad07e4fdbaba -> a9422eeaae74, new_dataset_models_take_2
   >> Copy 12 physical tables to sl_tables...
   >> Copy 41 SqlaTable to sl_datasets...
      Copy dataset owners...
      Link physical datasets with tables...
   >> Copy 2,326 table columns to sl_columns...
   Traceback (most recent call last):
     File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1276, in _execute_context
       self.dialect.do_execute(
     File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 608, in do_execute
       cursor.execute(statement, parameters)
   psycopg2.errors.NotNullViolation: null value in column "is_temporal" of relation "sl_columns" violates not-null constraint
   DETAIL:  Failing row contains (368c1f15-f08d-440b-b21d-b113e1a4e42d, 2021-12-03 08:09:13.776918, 2021-12-03 21:20:46.402427, 27, null, f, f, t, t, t, f, f, t, null, f, default_serial_num, STRING, null, , null, null, null, {"warning_markdown":null}, 1, 1).
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org