You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2026/04/07 14:02:50 UTC

(ofbiz-framework) branch trunk updated: Fixed: Enhance string escaping in MacroScreenRenderer

This is an automated email from the ASF dual-hosted git repository.

jacopoc pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5c627e288b Fixed: Enhance string escaping in MacroScreenRenderer
5c627e288b is described below

commit 5c627e288bf891c8e721e2a4c91d39d4fb58bae2
Author: Jacopo Cappellato <ja...@gmail.com>
AuthorDate: Tue Apr 7 14:50:46 2026 +0200

    Fixed: Enhance string escaping in MacroScreenRenderer
---
 .../org/apache/ofbiz/widget/renderer/macro/MacroScreenRenderer.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroScreenRenderer.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroScreenRenderer.java
index 5e31eb4ede..657167b257 100644
--- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroScreenRenderer.java
+++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroScreenRenderer.java
@@ -125,7 +125,7 @@ public class MacroScreenRenderer implements ScreenStringRenderer {
                 Object value = parameter.getValue();
                 if (value instanceof String) {
                     sb.append('"');
-                    sb.append(((String) value).replaceAll("\"", "\\\\\""));
+                    sb.append(((String) value).replace("\\", "\\\\").replace("\"", "\\\"").replace("$", "\\$"));
                     sb.append('"');
                 } else {
                     sb.append(value);