You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:33:03 UTC

[GitHub] [shardingsphere] TeslaCN opened a new issue, #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

TeslaCN opened a new issue, #20058:
URL: https://github.com/apache/shardingsphere/issues/20058

   ## Question
   
   My scenario is range sharding.
   
   ID distributes in [1, 32]
   
   Range sharding into 4 data sources:
   ds_0: [1, 8]
   ds_1: [9, 16]
   ds_2: [17, 24]
   ds_3: [25, 32]
   
   
   I thought the configuration was:
   ```yaml
       shardingAlgorithms:
         warehouse:
           type: VOLUME_RANGE
           props:
             range-lower: 1
             range-upper: 33
             sharding-volume: 8
   ```
   
   But the proper configuration is the following:
   ```yaml
       shardingAlgorithms:
         warehouse:
           type: VOLUME_RANGE
           props:
             range-lower: 9
             range-upper: 25
             sharding-volume: 8
   ```
   
   The properties may confuse users.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] closed issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear
URL: https://github.com/apache/shardingsphere/issues/20058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #20058:
URL: https://github.com/apache/shardingsphere/issues/20058#issuecomment-1365567949

   Since this issue has been inactive for a while, I'm closing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN closed issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear
URL: https://github.com/apache/shardingsphere/issues/20058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20058:
URL: https://github.com/apache/shardingsphere/issues/20058#issuecomment-1383439636

   Hi @TeslaCN, I took a look at the implementation of the `VOLUME_RANGE` algorithm. It is an auto sharding algorithm and is recommended to be used in the auto sharding configuration. Users do not need to care about the underlying actual table. 
   
   In addition, because the range sharding algorithm has values outside the boundary, two additional shardings are added to the algorithm to store these values outside the boundary. If we use this algorithm in the standard sharding algorithm, it will indeed be confusing, and I will think about how to optimize it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20058:
URL: https://github.com/apache/shardingsphere/issues/20058#issuecomment-1383414375

   @TeslaCN Thank you for your feedback, I will check this logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #20058:
URL: https://github.com/apache/shardingsphere/issues/20058#issuecomment-1383440100

   Thank you @strongduanmu 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #20058: Properties of VolumeBasedRangeShardingAlgorithm VOLUME_RANGE is not clear

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20058:
URL: https://github.com/apache/shardingsphere/issues/20058#issuecomment-1272348952

   Hello , this issue has not received a reply for several days.
   This issue is supposed to be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org