You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/12 03:40:58 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #361: chore: controller tree
tokers opened a new pull request #361:
URL: https://github.com/apache/apisix-ingress-controller/pull/361
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #361: chore: controller tree
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #361:
URL: https://github.com/apache/apisix-ingress-controller/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #361: chore: controller tree
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #361:
URL: https://github.com/apache/apisix-ingress-controller/pull/361#issuecomment-817598351
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=h1) Report
> Merging [#361](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=desc) (bafb9e5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ff3ca2e99dae47fb28c1031c586fb4a07ff3b524?el=desc) (ff3ca2e) will **decrease** coverage by `0.78%`.
> The diff coverage is `0.44%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 43.49% 42.70% -0.79%
==========================================
Files 40 38 -2
Lines 3458 3475 +17
==========================================
- Hits 1504 1484 -20
- Misses 1783 1820 +37
Partials 171 171
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `75.94% <ø> (ø)` | |
| [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <ø> (ø)` | |
| [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `8.90% <ø> (ø)` | |
| [pkg/ingress/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvbWFuaWZlc3QuZ28=) | `67.79% <ø> (ø)` | |
| [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=footer). Last update [ff3ca2e...bafb9e5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/361?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #361: chore: controller tree
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #361:
URL: https://github.com/apache/apisix-ingress-controller/pull/361#issuecomment-817500047
@gxthrj I fixed the issue that causing e2e test cases failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org