You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/14 18:45:22 UTC

[GitHub] attilapiros opened a new pull request #23540: [SPARK-26615][Core] Fixing transport server/client resource leaks in the core unittests

attilapiros opened a new pull request #23540: [SPARK-26615][Core] Fixing transport server/client resource leaks in the core unittests
URL: https://github.com/apache/spark/pull/23540
 
 
   ## What changes were proposed in this pull request?
   
   Fixing resource leaks where TransportClient/TransportServer instances are not closed properly.
   
   In StandaloneSchedulerBackend the null check is added because during the SparkContextSchedulerCreationSuite #"local-cluster" test it turned out that client is not initialised as org.apache.spark.scheduler.cluster.StandaloneSchedulerBackend#start isn't called. It throw an NPE and some resource remained in open. 
   
   ## How was this patch tested?
   
   By executing the unittests and using some extra temporary logging for counting created and closed TransportClient/TransportServer instances.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org