You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/04/03 16:46:40 UTC
[GitHub] [spark] amaliujia commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect
amaliujia commented on code in PR #40586:
URL: https://github.com/apache/spark/pull/40586#discussion_r1156209521
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -154,6 +158,9 @@ message Read {
//
// This is only supported by the JDBC data source.
repeated string predicates = 5;
+
+ // (Optional) Source table name for a streaming read. Not used in batch read.
+ string streaming_table_name = 6;
Review Comment:
https://github.com/apache/spark/blob/d3338c6879fd3e0b986654889f2e1e6407988dcc/connector/connect/common/src/main/protobuf/spark/connect/relations.proto#L122
This is how batch read a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org