[jira] [Updated] (DERBY-3955) test lang/selectivity.sql can be revived

["Myrna van Lunteren (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Myrna van Lunteren updated DERBY-3955:
--------------------------------------

    Attachment: DERBY-3955.diff2

Attaching a patch which adds the rest of selectivity.sql to the SelectivityTest.
Except for the section with t5, which in the old Cloudscape incarnation tested stored prepared statements, which are not supported in Derby, and without this, what remains of the test case does not test anything new.

This patch touches the following files:
D       java\testing\org\apache\derbyTesting\functionTests\tests\lang\selectivity_derby.properties
M       java\testing\org\apache\derbyTesting\functionTests\tests\lang\SelectivityTest.java
D       java\testing\org\apache\derbyTesting\functionTests\tests\lang\selectivity.sql

One thing to note - the original test was using selectivity_derby.properties, which had the following property:
  derby.language.statementCacheSize=0
It seems to me that the results without the property were reasonable, and I don't see that this would contribute to the test, so I did not try to preserve it in the junit test.

> test lang/selectivity.sql can be revived
> ----------------------------------------
>
>                 Key: DERBY-3955
>                 URL: https://issues.apache.org/jira/browse/DERBY-3955
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3955.diff1, DERBY-3955.diff2, derby-3955_sanityCheck_dont_commit_diff.txt, oldSelectivity.java
>
>
> One test that was contributed during the IBM contribution of derby code was not runnable at the time - lang/selectivity.sql.
> This test is still there, and I think might have some valuable regression tests if it gets adapted to the current functionality in Derby.
> Ideally too, it should get converted to junit, or at least be made to run through the langScripts junit suite.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)