You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/11/17 20:35:50 UTC

[GitHub] [daffodil] tuxji commented on pull request #681: Fix some code generation corner cases

tuxji commented on pull request #681:
URL: https://github.com/apache/daffodil/pull/681#issuecomment-971976115


   Latest push should fix failure running test_updateGeneratedCodeExamples in GitHubs Actions because test_updateGeneratedCodeExamples was previously run from the IDE, not from sbt, and the example generated_code files got their daffodil_program_version set to "null null" instead of "daffodil-runtime2 3.2.0-SNAPSHOT".  The IDE run tests directly from classes, not from jars, which results in these two lines in CodeGeneratorState.generateCodeFile producing "null":
   
   ```
       val program = this.getClass.getPackage.getImplementationTitle
       val version = this.getClass.getPackage.getImplementationVersion
   
            const char *daffodil_program_version = "$program $version";
   ```
   
   If anyone knows how to ensure these two lines produce the same output no matter whether code contributors run "sbt test" or run test_updateGeneratedCodeExamples from their IDE, then that would make test_updateGeneratedCodeExamples more robust.  Any ideas?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org