[GitHub] [incubator-iceberg] rdblue commented on issue #920: Implement Schema visitors for ORC value readers

[GitBox <gi...@apache.org>]

rdblue commented on issue #920: Implement Schema visitors for ORC value readers
URL: https://github.com/apache/incubator-iceberg/issues/920#issuecomment-612969043
 
 
   I think it's a good idea to add ORC schema visitors. I've found them helpful for Avro and Parquet because the recursive traversal is abstracted from the logic of each visitor. It's been easy to build new visitors. So I'm +1.
   
   I also want to point out that this doesn't have to be one big refactor. We can keep the current code as it is and just use the visitors for new things, and slowly convert over to the visitors in places where it makes sense. A minimal start is to define the visitor interface and visit method, then use it for what you need to, like the read builder in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org