You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/10/06 20:28:15 UTC

Review Request 39058: GEODE-385: fix test race

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39058/
-----------------------------------------------------------

Review request for geode and Kirk Lund.


Repository: geode


Description
-------

Region expiration was being enabled before the test suspended expiration.
This introduced a race in which the region could be expire destroyed
before the first put happened. Now expiry is suspended before region
expiration is configured.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 2a0a58160307e83156f31d61c75b1f04b95932e0 

Diff: https://reviews.apache.org/r/39058/diff/


Testing
-------

TXExpiryJUnitTest


Thanks,

Darrel Schneider

Re: Review Request 39058: GEODE-385: fix test race

Posted by Kirk Lund <ki...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39058/#review101675
-----------------------------------------------------------



gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java (line 324)
<https://reviews.apache.org/r/39058/#comment159130>

    I think I would move this if-else block inside the try { below


- Kirk Lund


On Oct. 6, 2015, 6:28 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39058/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 6:28 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Region expiration was being enabled before the test suspended expiration.
> This introduced a race in which the region could be expire destroyed
> before the first put happened. Now expiry is suspended before region
> expiration is configured.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 2a0a58160307e83156f31d61c75b1f04b95932e0 
> 
> Diff: https://reviews.apache.org/r/39058/diff/
> 
> 
> Testing
> -------
> 
> TXExpiryJUnitTest
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>