[jira] [Commented] (MINIFI-434) Preserve security properties when pulling a new config

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350821#comment-16350821 ] 

ASF GitHub Bot commented on MINIFI-434:
---------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi-minifi/pull/114

    MINIFI-434 - PullHttpChangeIngestor should preserve security properties

    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi-minifi c2-preserve-security

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
    
----
commit 866dc3a3f1add783a7615007900fe643b87a3aea
Author: Pierre Villard <pi...@...>
Date:   2018-02-01T18:20:43Z

    MINIFI-434 - PullHttpChangeIngestor should preserve security properties
    
    Signed-off-by: Pierre Villard <pi...@gmail.com>

----


> Preserve security properties when pulling a new config
> ------------------------------------------------------
>
>                 Key: MINIFI-434
>                 URL: https://issues.apache.org/jira/browse/MINIFI-434
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Pierre Villard
>            Priority: Major
>
> Situation (secured instances)
> MiNiFi == (pull) ==> C2 server == (pull template) ==> NiFi cluster
> Template to pull contains a RPG to perform S2S between MiNiFi and NiFi cluster over HTTPS.
> When a new version of the template is pulled, security properties are removed and S2S cannot be performed until config is manually fixed and agent restarted.
> Security properties should probably be excluded in this config update process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)