You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Anne Yu <an...@cloudera.com> on 2015/08/14 06:42:13 UTC
Review Request 37469: Clean up more dbprovider test failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/
-----------------------------------------------------------
Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
Bugs: SENTRY-850
https://issues.apache.org/jira/browse/SENTRY-850
Repository: sentry
Description
-------
Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java e21dfe3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
Diff: https://reviews.apache.org/r/37469/diff/
Testing
-------
https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
Thanks,
Anne Yu
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/#review95778
-----------------------------------------------------------
Ship it!
Thanks for tackling this Anne! Test clean up looks much better now!
- Sravya Tirukkovalur
On Aug. 18, 2015, 8:12 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37469/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 8:12 p.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-850
> https://issues.apache.org/jira/browse/SENTRY-850
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
>
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
> org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossDbOps.java 8d23ea6
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java e60225c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java f98caa9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java 9606b41
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java a35cf21
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 9fb6f7f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java 66e81a8
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java f0d8ac4
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java 659d820
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java 58a27a6
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java 194fe63
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java 3a718e8
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java 30541d9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java 8adc5bb
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 46c6cbb
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java be9f601
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java 2c14c82
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java 30041c5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java c13222f
>
> Diff: https://reviews.apache.org/r/37469/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 8:12 p.m.)
Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
Changes
-------
Addressed Sravya and Colin's comments, deeply cleaned more stuffs:
1. configured setMetastoreListener = true for all dbprovider and hive tests; disabled a couple of them which need more work;
2. configured clearDbPerTest = true for all such tests; and cleaned up all the flaky test failures.
https://builds.apache.org/job/PreCommit-SENTRY-Build/800/
Bugs: SENTRY-850
https://issues.apache.org/jira/browse/SENTRY-850
Repository: sentry
Description
-------
Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossDbOps.java 8d23ea6
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java e60225c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java f98caa9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java 9606b41
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java a35cf21
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java 9fb6f7f
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java 66e81a8
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java f0d8ac4
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java 659d820
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java 58a27a6
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java 194fe63
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java 3a718e8
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java 30541d9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java 8adc5bb
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 46c6cbb
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java be9f601
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java 2c14c82
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java 30041c5
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java c13222f
Diff: https://reviews.apache.org/r/37469/diff/
Testing
-------
https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
Thanks,
Anne Yu
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Anne Yu <an...@cloudera.com>.
> On Aug. 14, 2015, 5:30 a.m., Colin Ma wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java, line 51
> > <https://reviews.apache.org/r/37469/diff/1/?file=1039869#file1039869line51>
> >
> > clearDbAfterPerTest and clearDbBeforePerTest do the same thing, maybe only one set true is enough.
OK, looks keeping one is good enough. Let me update it.
- Anne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/#review95388
-----------------------------------------------------------
On Aug. 14, 2015, 4:42 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37469/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:42 a.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-850
> https://issues.apache.org/jira/browse/SENTRY-850
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
>
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
> org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java e21dfe3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
>
> Diff: https://reviews.apache.org/r/37469/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/#review95388
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java (line 51)
<https://reviews.apache.org/r/37469/#comment150337>
clearDbAfterPerTest and clearDbBeforePerTest do the same thing, maybe only one set true is enough.
- Colin Ma
On Aug. 14, 2015, 4:42 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37469/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:42 a.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-850
> https://issues.apache.org/jira/browse/SENTRY-850
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
>
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
> org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java e21dfe3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
>
> Diff: https://reviews.apache.org/r/37469/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Anne Yu <an...@cloudera.com>.
> On Aug. 14, 2015, 6:33 p.m., Sravya Tirukkovalur wrote:
> > Can we setMetastoreListener = true for these updated tests, so that we can catch any further regressions in pre commit runs rather than real cluster runs? I see that there are more tests than covered on this jira which would fail if we make the default to true. https://issues.apache.org/jira/browse/SENTRY-830?focusedCommentId=14652573&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652573
> > so we can probably set it to false just for these test classes which need more work and file a follow on jira.
Agreed!
- Anne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/#review95458
-----------------------------------------------------------
On Aug. 14, 2015, 4:42 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37469/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:42 a.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-850
> https://issues.apache.org/jira/browse/SENTRY-850
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
>
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
> org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java e21dfe3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
>
> Diff: https://reviews.apache.org/r/37469/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 37469: Clean up more dbprovider test failures
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37469/#review95458
-----------------------------------------------------------
Ship it!
Can we setMetastoreListener = true for these updated tests, so that we can catch any further regressions in pre commit runs rather than real cluster runs? I see that there are more tests than covered on this jira which would fail if we make the default to true. https://issues.apache.org/jira/browse/SENTRY-830?focusedCommentId=14652573&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652573
so we can probably set it to false just for these test classes which need more work and file a follow on jira.
- Sravya Tirukkovalur
On Aug. 14, 2015, 4:42 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37469/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:42 a.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-850
> https://issues.apache.org/jira/browse/SENTRY-850
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Clean up more dbprovider test failures: run tests on a real cluster or setMetastoreListener = true, if db/tab gets recreated their associated privileges will be deleted.
>
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic
> org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended
> org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13
> org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10
> org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java 9ed38ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java e1cda29
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java 5324656
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java e21dfe3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java 43a310f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java 7c9a66d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java c47686b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 626fd40
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7c7c63e
>
> Diff: https://reviews.apache.org/r/37469/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console
>
>
> Thanks,
>
> Anne Yu
>
>