You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/08/18 06:48:15 UTC

[GitHub] incubator-weex pull request #617: * [android] compute content size and offse...

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/617

    * [android] compute content size and offset based on css layout result

    Testcase:
    list: http://dotwe.org/weex/0eacaa08c50a9ef00474f2333c56743c
    waterfall: http://dotwe.org/vue/7a9195643e9e8da352b0d879cdbe68c0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-bugfix-list-onscroll

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/617.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #617
    
----
commit cfc14120db76a1881711a4b68313a863a15e94f2
Author: misakuo <mi...@apache.org>
Date:   2017-08-18T03:29:05Z

    * [android] ignore scroll event when list can not scroll vertically

commit e22f02a8cd3a4183af919b7296e25ffd3cb71295
Author: misakuo <mi...@apache.org>
Date:   2017-08-18T06:46:49Z

    * [android] compute content size & content offset based on layout result

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #617: * [android] compute content size and offset based...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/617
  
    
    <!--
      1 failure:  This PR modify SD...
      2 warning:  No Changelog chan..., This PR should up...
      
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #617: * [android] compute content size and offse...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/617


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---