You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2023/09/26 12:16:10 UTC
[maven-project-info-reports-plugin] branch master updated: [MNG-7416] Simplify Boolean expressions and returns (#63)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-project-info-reports-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new c16ec94 [MNG-7416] Simplify Boolean expressions and returns (#63)
c16ec94 is described below
commit c16ec9433ccc394a8d8e50d5367a0b0a7881c8f7
Author: Tim te Beek <ti...@gmail.com>
AuthorDate: Tue Sep 26 14:16:06 2023 +0200
[MNG-7416] Simplify Boolean expressions and returns (#63)
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/SEvWu02zw?organizationId=QXBhY2hlIE1hdmVu
Co-authored-by: Moderne <te...@moderne.io>
---
src/main/java/org/apache/maven/report/projectinfo/ScmReport.java | 7 +------
.../java/org/apache/maven/report/projectinfo/SummaryReport.java | 6 +-----
.../projectinfo/dependencies/renderer/DependenciesRenderer.java | 2 +-
.../maven/report/projectinfo/ProjectInfoReportUtilsTest.java | 2 +-
4 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java b/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java
index a029d58..d86103b 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/ScmReport.java
@@ -817,12 +817,7 @@ public class ScmReport extends AbstractProjectInfoReport {
if (scmProvider == null || scmProvider.isEmpty()) {
return false;
}
-
- if (scmRepository != null && scmProvider.equalsIgnoreCase(scmRepository.getProvider())) {
- return true;
- }
-
- return false;
+ return scmRepository != null && scmProvider.equalsIgnoreCase(scmRepository.getProvider());
}
}
}
diff --git a/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java b/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
index 7e78e51..a2cb397 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java
@@ -225,11 +225,7 @@ public class SummaryReport extends AbstractProjectInfoReport {
// maven-compiler-plugin ?
Xpp3Dom pluginConfig =
project.getGoalConfiguration("org.apache.maven.plugins", "maven-compiler-plugin", null, null);
- if (pluginConfig != null) {
- return true;
- }
-
- return false;
+ return pluginConfig != null;
}
}
}
diff --git a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
index 6b9925f..4981acc 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
@@ -896,7 +896,7 @@ public class DependenciesRenderer extends AbstractProjectInfoRenderer {
if (!node.getChildren().isEmpty()) {
boolean toBeIncluded = false;
- List<DependencyNode> subList = new ArrayList<DependencyNode>();
+ List<DependencyNode> subList = new ArrayList<>();
for (DependencyNode dep : node.getChildren()) {
if (dependencies.getAllDependencies().contains(dep.getArtifact())) {
subList.add(dep);
diff --git a/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java b/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java
index d6031b3..0ff3b55 100644
--- a/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java
+++ b/src/test/java/org/apache/maven/report/projectinfo/ProjectInfoReportUtilsTest.java
@@ -60,7 +60,7 @@ public class ProjectInfoReportUtilsTest extends AbstractMojoTestCase {
protected void setUp() throws Exception {
super.setUp();
- final List<org.apache.maven.settings.Server> servers = new ArrayList<org.apache.maven.settings.Server>();
+ final List<org.apache.maven.settings.Server> servers = new ArrayList<>();
org.apache.maven.settings.Server server = new org.apache.maven.settings.Server();
server.setId("localhost");
server.setUsername("admin");