You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 09:29:44 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #9056:
[FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0
in sql parser & flink planner
KurtYoung commented on a change in pull request #9056: [FLINK-13185] [sql-parser][table-planner] Bump Calcite dependency to 1.20.0 in sql parser & flink planner
URL: https://github.com/apache/flink/pull/9056#discussion_r301964296
##########
File path: flink-table/flink-table-planner/pom.xml
##########
@@ -148,24 +148,29 @@ under the License.
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<!-- When updating the Calcite version, make sure to update the dependency exclusions -->
- <version>1.18.0</version>
+ <version>1.20.0</version>
<exclusions>
<!--
-
- Dependencies that are not needed for how we use Calcite right now.
-
- "mvn dependency:tree" as of Calcite 1.18:
-
- [INFO] +- org.apache.calcite:calcite-core:jar:1.18.0:compile
- [INFO] | +- org.apache.calcite.avatica:avatica-core:jar:1.13.0:compile
- [INFO] | +- org.apache.calcite:calcite-linq4j:jar:1.18.0:compile
- [INFO] | +- org.apache.commons:commons-lang3:jar:3.3.2:compile
- [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.9.6:compile
- [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.6:compile
- [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.6:compile
+ "mvn dependency:tree" as of Calcite 1.20:
+
+ [INFO] +- org.apache.calcite:calcite-core:jar:1.20.0:compile
Review comment:
Do we have to depend on all of these? It increased a lot just for upgrading calcite version. Could you remove useless dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services